HoustonPutman commented on code in PR #3273:
URL: https://github.com/apache/solr/pull/3273#discussion_r2004243474
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -294,15 +294,16 @@ private PreparedRequest preparePutOrPost(
final PipedInputStream sink = new PipedInputStream(source);
bodyPublisher = HttpRequest.BodyPublishers.ofInputStream(() -> sink);
- contentWritingFuture =
- executor.submit(
- () -> {
- try (source) {
- contentWriter.write(source);
- } catch (Exception e) {
- log.error("Cannot write Content Stream", e);
- }
- });
+ executor.submit(
+ () -> {
+ try (source) {
+ contentWriter.write(source);
+ contentWritingFuture.complete(null);
+ } catch (Exception e) {
Review Comment:
Can you change this to `Throwable`? We don't want a possibility of this not
being caught.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
