gerlowskija commented on code in PR #779: URL: https://github.com/apache/solr-operator/pull/779#discussion_r2027279783
########## helm/solr-operator/Chart.yaml: ########## @@ -55,6 +55,11 @@ annotations: # Allowed syntax is described at: https://artifacthub.io/docs/topics/annotations/helm/#example # 'kind' accepts values: "added", "changed", "deprecated", "removed", "fixed" and "security" artifacthub.io/changes: | + - kind: added + description: Ability to configure log encoder, level and stacktrace level + links: + - name: Github Issue + url: https://github.com/apache/solr-operator/issues/778 Review Comment: ```suggestion links: - name: Github Issue url: https://github.com/apache/solr-operator/issues/778 - name: Github PR url: https://github.com/apache/solr-operator/pull/779 ``` ########## helm/solr-operator/README.md: ########## @@ -191,6 +191,10 @@ The command removes all the Kubernetes components associated with the chart and | tolerations | []object | | Specify a list of Kubernetes tolerations for the Solr Operator pod | | priorityClassName | string | `""` | Give a priorityClassName for the Solr Operator pod | | sidecarContainers | []object | | An optional list of additional containers to run along side the Solr Operator in its pod | +| logger.devel | boolean | `false` | Enable development mode for the Solr Operator logger. This will log at the debug level with the console encoder. Default is `false` which logs at `info` level with `json` encoder. | Review Comment: [0] I could see the dev/prod distinction being useful for setting defaults totally unrelated to logging (docker image tag, resource limits, etc.). Wdyt about moving this "mode" flag up to the top level, so it's easier to expand later to cover other things if desired? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
