dsmiley commented on code in PR #3307:
URL: https://github.com/apache/solr/pull/3307#discussion_r2027052351


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/JavaBinResponseParser.java:
##########
@@ -27,13 +27,13 @@
 /**
  * @since solr 1.3
  */
-public class BinaryResponseParser extends ResponseParser {
+public class JavaBinResponseParser extends ResponseParser {
   public static final String BINARY_CONTENT_TYPE_V2 = 
"application/vnd.apache.solr.javabin";
   public static final String BINARY_CONTENT_TYPE = "application/octet-stream";

Review Comment:
   Can you please rename these constants as well?  e.g. `JAVABIN_CONTENT_TYPE`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to