HoustonPutman commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2779692896
> Your changes since my last review are nice/simple. I'm not sure how to resolve maybe differing views on what should be consolidated or removed, but happy to defer to your judgement Houston (or Gus). At least hearing "remove ___(whatever)" is probably generally a good thing for simplicity :-) I mean, this really is just a refactoring (loose interpretation of that word) of what already existed, and giving it a better name and user-facing support. This was only really used in 1 place (Spellcheck Collation), and didn't work in every way that Solr supports searching now. So "removing" isn't really true, it's really replacing an internal way of doing something. Hopefully no one disagrees about that part 😅 As for the response difference between `segmentTerminatedEarly` and `maxHitsTerminatedEarly` in the responseHeader, I think it's probably best to keep those separate. `segmentTerminatedEarly` really only tells you that the `numFound` information is wrong, since we know that because of the sort, the best documents were found. As for `maxHitsTerminatedEarly`, numFound will likely be wrong (as with the previous flag), but the results are also probably not the most relevant, since we don't have the sorting guarantees that `segmentTerminatedEarly` gives. So I think it does give useful information back to the "caller". I'm also not against cleaning this up in the future, having a better way of exposing the ways in which the response isn't giving the exactly correct information. That would be a big enough change affecting multiple features (maxHitsAllowed, circuitBreakers, blockMax-wand, segmentTerminatedEarly, etc) that it probably belongs in its own ticket/PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
