iamsanjay commented on PR #2876:
URL: https://github.com/apache/solr/pull/2876#issuecomment-2774697417
We're hitting a NullPointerException in async code when calling
TraceUtils.getSpan(req) after upgrading to Jetty 12. The root cause is that
Jetty 12 no longer guarantees that ServletApiReq
abumarjikar commented on code in PR #3307:
URL: https://github.com/apache/solr/pull/3307#discussion_r2028126828
##
solr/CHANGES.txt:
##
@@ -176,6 +176,8 @@ Other Changes
* SOLR-14070: Deprecate CloudSolrClient's ZooKeeper Hosts constructor.
(Abhishek Umarjikar)
+* SOLR-177
abumarjikar commented on code in PR #3307:
URL: https://github.com/apache/solr/pull/3307#discussion_r2027410812
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/JavaBinResponseParser.java:
##
@@ -27,13 +27,13 @@
/**
* @since solr 1.3
*/
-public class BinaryResponseP
QFREEE commented on code in PR #3305:
URL: https://github.com/apache/solr/pull/3305#discussion_r2027661461
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -1183,6 +1191,18 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedExcept
[
https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940783#comment-17940783
]
Matthew Biscocho commented on SOLR-17458:
-
I have a foundation for this working a
dsmiley commented on code in PR #3307:
URL: https://github.com/apache/solr/pull/3307#discussion_r2027717015
##
solr/CHANGES.txt:
##
@@ -176,6 +176,8 @@ Other Changes
* SOLR-14070: Deprecate CloudSolrClient's ZooKeeper Hosts constructor.
(Abhishek Umarjikar)
+* SOLR-17703:
abumarjikar commented on code in PR #3307:
URL: https://github.com/apache/solr/pull/3307#discussion_r2027726674
##
solr/CHANGES.txt:
##
@@ -176,6 +176,8 @@ Other Changes
* SOLR-14070: Deprecate CloudSolrClient's ZooKeeper Hosts constructor.
(Abhishek Umarjikar)
+* SOLR-177
gerlowskija commented on PR #3023:
URL: https://github.com/apache/solr/pull/3023#issuecomment-2776308451
Hey @colvinco - my apologies - I missed some of the updates you put on this
PR. Trying to catch up now!
Will answer some specific questions you mentioned above, and then I'll wade
dsmiley commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2027539523
##
solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2027550274
##
solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940800#comment-17940800
]
David Smiley commented on SOLR-17703:
-
Thanks for contributing! For a few minutes I
janhoy commented on code in PR #779:
URL: https://github.com/apache/solr-operator/pull/779#discussion_r2027447971
##
helm/solr-operator/README.md:
##
@@ -191,6 +191,10 @@ The command removes all the Kubernetes components
associated with the chart and
| tolerations | []object |
[
https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940817#comment-17940817
]
Abhishek Umarjikar commented on SOLR-17703:
---
[~dsmiley] Thanks for considering
gerlowskija commented on code in PR #3023:
URL: https://github.com/apache/solr/pull/3023#discussion_r2027395629
##
solr/core/src/test/org/apache/solr/handler/admin/api/V2APISmokeTest.java:
##
@@ -0,0 +1,457 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/SOLR-14070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-14070.
-
Resolution: Fixed
[~epugh] , you inquired if this should go to Solr 9. I'm a little timid about
dsmiley commented on code in PR #3305:
URL: https://github.com/apache/solr/pull/3305#discussion_r2027736206
##
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##
@@ -1183,6 +1191,18 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedExcept
[
https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940692#comment-17940692
]
Abhishek Umarjikar edited comment on SOLR-17703 at 4/3/25 12:52 PM:
---
dsmiley commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2027510686
##
solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
dsmiley commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2027509100
##
solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17703:
--
Labels: newdev pull-request-available (was: newdev)
> BinaryResponseParser and BinaryRequestWr
abumarjikar commented on PR #3307:
URL: https://github.com/apache/solr/pull/3307#issuecomment-2776412091
@dsmiley Changes made for constant rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
QFREEE commented on code in PR #3305:
URL: https://github.com/apache/solr/pull/3305#discussion_r2027864522
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -865,6 +871,76 @@ public void removeLiveNodesListener(LiveNodesListener
listener) {
HoustonPutman commented on PR #3222:
URL: https://github.com/apache/solr/pull/3222#issuecomment-2777236714
To be explicit about the large amount of code changed here, there was no
support for non-"score" named score return fields, such as "temp:score"
(aliased return fields), in distributed
solrbot closed pull request #3095: Update dependency de.thetaphi.forbiddenapis
to v3.8 - autoclosed
URL: https://github.com/apache/solr/pull/3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dsmiley commented on code in PR #3305:
URL: https://github.com/apache/solr/pull/3305#discussion_r2027934645
##
solr/core/src/test/org/apache/solr/cloud/overseer/ZkStateReaderTest.java:
##
@@ -894,68 +894,57 @@ public void testDeletePrsCollection() throws Exception {
}
}
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-17447:
--
Description:
Currently there are 3 mechanisms to control # of hits for a query
* Use of the _t
dsmiley commented on PR #3282:
URL: https://github.com/apache/solr/pull/3282#issuecomment-2776630387
> What's the relationship between this PR and the one that underlies it? Are
you looking for consensus on both before you merge the underlying one?
Yes; these are important changes th
[
https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940865#comment-17940865
]
David Smiley commented on SOLR-17458:
-
It'd be a huge code change, no doubt! Excitin
epugh commented on PR #3190:
URL: https://github.com/apache/solr/pull/3190#issuecomment-2775235831
Messaging doesn't seem like anyone would care, so goign to skip changes.txt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
epugh commented on code in PR #3190:
URL: https://github.com/apache/solr/pull/3190#discussion_r2026678313
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -411,21 +411,25 @@ private static void printHelp() {
print(
"zk l
[
https://issues.apache.org/jira/browse/SOLR-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940632#comment-17940632
]
ASF subversion and git services commented on SOLR-17674:
Commit 7
epugh merged PR #3190:
URL: https://github.com/apache/solr/pull/3190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #3295:
URL: https://github.com/apache/solr/pull/3295#issuecomment-2775105685
I spot checked a couple of places and it all seems to make sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
igiguere commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r2027024323
##
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##
@@ -411,6 +410,7 @@ public void contextInitialized(ServletContextEvent event) {
gerlowskija commented on PR #3299:
URL: https://github.com/apache/solr/pull/3299#issuecomment-2775490954
Alright, the JAX-RS code is in place so I've marked this as "Ready for
Review".
One thing that I've left out of this PR, that we'll want to think through
and handle separately are
[
https://issues.apache.org/jira/browse/SOLR-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940666#comment-17940666
]
Jan Høydahl commented on SOLR-17725:
Please clarify your intent with this Jira before
gerlowskija commented on PR #3299:
URL: https://github.com/apache/solr/pull/3299#issuecomment-2775496621
Still TODO:
- manual testing
- possible integration with #3023 ?
- some generated SolrRequest fixes
- check
- run tests
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940666#comment-17940666
]
Jan Høydahl edited comment on SOLR-17725 at 4/3/25 11:48 AM:
-
gerlowskija commented on code in PR #3282:
URL: https://github.com/apache/solr/pull/3282#discussion_r2026858878
##
solr/solrj/src/java/org/apache/solr/client/solrj/JacksonDataBindResponseParser.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/SOLR-17674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17674.
--
Fix Version/s: main (10.0)
Assignee: Eric Pugh
Resolution: Fixed
> Update SolrCLI to re
abumarjikar opened a new pull request, #3307:
URL: https://github.com/apache/solr/pull/3307
https://issues.apache.org/jira/browse/SOLR-17703
# Description
This PR targets to rename the BinaryResponseParser and BinaryRequestWriter
including StreamingJavaBinResponsePa
igiguere commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r2027025386
##
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##
@@ -411,6 +410,7 @@ public void contextInitialized(ServletContextEvent event) {
[
https://issues.apache.org/jira/browse/SOLR-17683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940716#comment-17940716
]
ASF subversion and git services commented on SOLR-17683:
Commit f
HoustonPutman commented on PR #2960:
URL: https://github.com/apache/solr/pull/2960#issuecomment-2776005934
I need to add a changelog entry, but I think this is good to go, and will
probably merge sometime tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to
44 matches
Mail list logo
