QFREEE commented on code in PR #3305:
URL: https://github.com/apache/solr/pull/3305#discussion_r2027661461
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -1183,6 +1191,18 @@ private void createEphemeralLiveNode() throws
KeeperException, InterruptedExcept
zkClient.multi(ops);
}
+ private byte[] buildLiveNodeData() {
Review Comment:
I could move the method to ZkStateReader, however, methods like
getNodeName() are in ZkController. There is no CoreContainer in ZkStateReader
to get node roles in ZkStateReader neither.
I think the problem is [createEphemeralLiveNode()]
(https://github.com/apache/solr/blob/83ab0971c0176f794738ff0649bad00e6277c024/solr/core/src/java/org/apache/solr/cloud/ZkController.java#L1167)
is in ZkController, perhpas it should be refactored to ZkStateReader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
