[ https://issues.apache.org/jira/browse/SOLR-17703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940817#comment-17940817 ]
Abhishek Umarjikar commented on SOLR-17703: ------------------------------------------- [~dsmiley] Thanks for considering the PR. And Yes i saw similar ticket, i verified if the changes has been made already or not in code. 😁 > BinaryResponseParser and BinaryRequestWriter rename to "JavaBin..." > ------------------------------------------------------------------- > > Key: SOLR-17703 > URL: https://issues.apache.org/jira/browse/SOLR-17703 > Project: Solr > Issue Type: Improvement > Components: SolrJ > Reporter: David Smiley > Priority: Blocker > Labels: newdev, pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > SolrJ BinaryRequestWriter and BinaryResponseParser should be renamed to > replace "Binary" with "JavaBin". Same with StreamingBinaryResponseParser. > This clarifies that they are for "JavaBin" specifically, and not binary > generically, and it's also more consistent with the other uses of "JavaBin" > named things. The poor naming has led to accidental misuse of these. > Separately in another issue, the Solr side JavaBinResponseWriter was renamed > from a worse name. > 10.0 only, obviously. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org