gerlowskija commented on PR #3023:
URL: https://github.com/apache/solr/pull/3023#issuecomment-2776308451
Hey @colvinco - my apologies - I missed some of the updates you put on this
PR. Trying to catch up now!
Will answer some specific questions you mentioned above, and then I'll wade
in for a broader review...
> Does it make sense to test the /core APIs with a cloud deployment, or do I
need to run a standalone?
You wouldn't want to hit those APIs in SolrCloud generally - the `/core`
APIs are built to work in standalone mode so they won't update the ZooKeeper
state to reflect created cores, etc. But for testing purposes if it's more
convenient to exercise those APIs in a SolrCloud cluster, I think that's
reasonable.
> I guess the /shards APIs mostly make sense when using implicit routing
rather than composite?
Yep - exactly!
----
On the overall approach you shared above:
```
public void testCollectionsApi() throws Exception {
canGet("/collections");
canPost("/collections", """
{
"name": "testCollection",
"numShards": 1
}
""");
```
This is nice and concise; I like it!
One tradeoff I guess is whether we want the test to be explicit about the
HTTP details (the path, method, request body format, etc.), or whether it
should use the SolrJ classes that we're auto-generating for the v2 APIs.
The former approach asserts that the API looks exactly the way we want it
to. The latter approach loses that explicitness by abstracting it behind
client objects, but it tests the client and server code both which is nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
