igiguere commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r2027024323
##########
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##########
@@ -411,6 +410,7 @@ public void contextInitialized(ServletContextEvent event) {
// Default servlet as a fall-through
root.addServlet(Servlet404.class, "/");
+ chain = root;
Review Comment:
I'm confused. Why initialize 'chain' as Handler.Wrapper only to override
that here, and make 'chain' a ServletContextHandler?
##########
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java:
##########
@@ -411,6 +410,7 @@ public void contextInitialized(ServletContextEvent event) {
// Default servlet as a fall-through
root.addServlet(Servlet404.class, "/");
+ chain = root;
}
chain = injectJettyHandlers(chain);
Review Comment:
... and now 'chain' becomes what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
