psalagnac commented on code in PR #3036:
URL: https://github.com/apache/solr/pull/3036#discussion_r1918216036
##
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java:
##
@@ -207,6 +210,47 @@ protected static void waitForState(
}
}
+ /**
+ * Wait
psalagnac commented on code in PR #3036:
URL: https://github.com/apache/solr/pull/3036#discussion_r191871
##
solr/solrj/src/test/org/apache/solr/common/cloud/PerReplicaStatesIntegrationTest.java:
##
@@ -245,50 +245,42 @@ public void testMultipleTransitions() throws Exception
dsmiley commented on code in PR #254:
URL: https://github.com/apache/solr/pull/254#discussion_r1918644012
##
solr/benchmark/src/java/org/apache/solr/bench/generators/StringsDSL.java:
##
@@ -0,0 +1,481 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
solrbot commented on PR #3039:
URL: https://github.com/apache/solr/pull/3039#issuecomment-2594823102
### ⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably
do not want to merge this PR as-is.
♻ Renovate will retry this branch,
solrbot opened a new pull request, #3039:
URL: https://github.com/apache/solr/pull/3039
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [com.github.spotbugs:spotbugs-annotations](https://spotbugs.github.io/)
([source](https://redi
Stefan Weil created SOLR-17622:
--
Summary: Spelling bugs in the Solr reference guide
Key: SOLR-17622
URL: https://issues.apache.org/jira/browse/SOLR-17622
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913787#comment-17913787
]
David Smiley commented on SOLR-17623:
-
Perhaps the Map methods that modify can be Uns
[
https://issues.apache.org/jira/browse/SOLR-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913788#comment-17913788
]
Eric Pugh commented on SOLR-17622:
--
Someday I'd love to get spell checking (and even sty
dsmiley commented on PR #2932:
URL: https://github.com/apache/solr/pull/2932#issuecomment-2596114823
Yes; simply add methods to SimpleOrderedMap.
JIRA: Should be in the header of the page:
https://selfserve.apache.org/jira-account.html
--
This is an automated message from the A
epugh commented on PR #3029:
URL: https://github.com/apache/solr/pull/3029#issuecomment-2596190916
Thanks for supplying some context. I looked at the code, and it all made
sense, though I confess to not being an expert in this area!
1) Do we need additional Ref Guide docs at this
[
https://issues.apache.org/jira/browse/SOLR-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913822#comment-17913822
]
Stefan Weil commented on SOLR-17622:
Related fix: [https://github.com/apache/solr/pul
[
https://issues.apache.org/jira/browse/SOLR-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Weil updated SOLR-17622:
---
Status: Patch Available (was: Open)
> Spelling bugs in the Solr reference guide
> --
mlbiscoc commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1918615357
##
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##
@@ -353,12 +353,14 @@ public ClassLoader getClassLoader() {
*/
@Override
public InputStre
[
https://issues.apache.org/jira/browse/SOLR-17623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17623:
Labels: newdev (was: )
> SimpleOrderedMap should implement Map
> -
dsmiley commented on PR #2932:
URL: https://github.com/apache/solr/pull/2932#issuecomment-2595899528
If you're interested: https://issues.apache.org/jira/browse/SOLR-17623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
[
https://issues.apache.org/jira/browse/SOLR-17622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17622:
---
Labels: good-first-issue newdev (was: )
> Spelling bugs in the Solr reference guide
> --
David Smiley created SOLR-17623:
---
Summary: SimpleOrderedMap should implement Map
Key: SOLR-17623
URL: https://issues.apache.org/jira/browse/SOLR-17623
Project: Solr
Issue Type: Improvement
renatoh commented on PR #2932:
URL: https://github.com/apache/solr/pull/2932#issuecomment-2596022827
sure, i will give it a go.
so the idea is to keep the ArrayList from NamedList as internal data
structure but do i implement java.util.Map, correct?
How do I get access to Jira?
--
T
[
https://issues.apache.org/jira/browse/SOLR-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913939#comment-17913939
]
Yue Yu commented on SOLR-17221:
---
[~dsmiley] Glad I can help. Thank you for the suggestions
dsmiley commented on PR #3027:
URL: https://github.com/apache/solr/pull/3027#issuecomment-2597402160
In the description, I said Solr 10 only but actually I see no reason why
these **internal** changes couldn't be applied to branch_9x as well so I'll do
that too.
--
This is an automated m
iamsanjay commented on PR #2876:
URL: https://github.com/apache/solr/pull/2876#issuecomment-2597515617
Most of the test cases, I believe, are failing due to some issues with the
Restore Command. Now in the logs, there is no much detail regarding the issue
the only thing I got it.
```
dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919639117
##
solr/core/src/java/org/apache/solr/cloud/ZkSolrResourceLoader.java:
##
@@ -121,7 +120,7 @@ public InputStream openResource(String resource) throws
IOException {
[
https://issues.apache.org/jira/browse/SOLR-17540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913950#comment-17913950
]
David Smiley commented on SOLR-17540:
-
Can you please post a branch_9x PR for that Er
[
https://issues.apache.org/jira/browse/SOLR-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17611.
-
Fix Version/s: 9.9
Resolution: Fixed
> SolrJ should pass Solr version in the user-agent
>
[
https://issues.apache.org/jira/browse/SOLR-17624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17624:
Labels: newdev (was: )
> NavigableObject should use generics for some get methods
> --
David Smiley created SOLR-17624:
---
Summary: NavigableObject should use generics for some get methods
Key: SOLR-17624
URL: https://issues.apache.org/jira/browse/SOLR-17624
Project: Solr
Issue Typ
dsmiley merged PR #2927:
URL: https://github.com/apache/solr/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913861#comment-17913861
]
ASF subversion and git services commented on SOLR-17611:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-17611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913862#comment-17913862
]
ASF subversion and git services commented on SOLR-17611:
Commit d
epugh commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919118773
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -428,10 +428,10 @@ public boolean fetch(String path, String from) {
@Override
public void
dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919163141
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -458,25 +458,25 @@ public void syncToAllNodes(String path) throws
IOException {
}
@Ov
psalagnac commented on PR #3036:
URL: https://github.com/apache/solr/pull/3036#issuecomment-2596891316
> ZkStateReader.waitForState has the wait unit params immediately after the
collection name. I think the new waitForState you added should be consistent.
Keeping the functional arg at the
solrbot commented on PR #2996:
URL: https://github.com/apache/solr/pull/2996#issuecomment-2597249017
### ⚠️ Artifact update problem
Renovate failed to update artifacts related to this branch. You probably do
not want to merge this PR as-is.
♻ Renovate will retry this branch, in
dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919169585
##
solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java:
##
@@ -195,54 +195,69 @@ private void showFromZooKeeper(
}
// Return the file indi
dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919166386
##
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##
@@ -458,25 +458,25 @@ public void syncToAllNodes(String path) throws
IOException {
}
@Ov
dsmiley commented on code in PR #3032:
URL: https://github.com/apache/solr/pull/3032#discussion_r1919153386
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/InputStreamResponseParser.java:
##
@@ -21,9 +21,16 @@
import org.apache.solr.client.solrj.ResponseParser;
import
laminelam commented on PR #3029:
URL: https://github.com/apache/solr/pull/3029#issuecomment-2596843533
@epugh
1. Yes planning to add some new entries to the ref guide.
2. Yes you can use it to login to the Admin UI. This is already the case
right now. The only thing this PR do
dsmiley commented on PR #2924:
URL: https://github.com/apache/solr/pull/2924#issuecomment-2596877815
As a general comment, I want to ensure we're careful converting some Strings
to Paths. It's only safe if we're certain that it's exactly a file system
path. Paths resolved inside a Directo
David Smiley created SOLR-17625:
---
Summary: Deprecate NamedList.findRecursive (use _get instead)
Key: SOLR-17625
URL: https://issues.apache.org/jira/browse/SOLR-17625
Project: Solr
Issue Type: I
[
https://issues.apache.org/jira/browse/SOLR-17625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17625:
Labels: newdev (was: )
> Deprecate NamedList.findRecursive (use _get instead)
> --
[
https://issues.apache.org/jira/browse/SOLR-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-17221.
-
Fix Version/s: 9.9
Resolution: Fixed
I pushed this to branch_9x today but not seeing the b
41 matches
Mail list logo
