dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919639117


##########
solr/core/src/java/org/apache/solr/cloud/ZkSolrResourceLoader.java:
##########
@@ -121,7 +120,7 @@ public InputStream openResource(String resource) throws 
IOException {
 
     try {
       // delegate to the class loader (looking into $INSTANCE_DIR/lib jars)
-      is = 
classLoader.getResourceAsStream(resource.replace(File.separatorChar, '/'));
+      is = classLoader.getResourceAsStream(Path.of(resource).toString());

Review Comment:
   But I think it doesn't work; not on Windows.  I thought I commented 
elsewhere in that lengthy review that all `Path.of(resource).toString()` that 
you are adding is probably flawed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to