dsmiley commented on PR #2924: URL: https://github.com/apache/solr/pull/2924#issuecomment-2596877815
As a general comment, I want to ensure we're careful converting some Strings to Paths. It's only safe if we're certain that it's exactly a file system path. Paths resolved inside a DirectoryFactory/Directory are not necessarily literally on the file system (it's an abstraction to data that could be in HDFS or S3 or...). It'd be nice to use a Path for this anyway but shouldn't be without a custom FileSystem impl (very out of scope here). Same for ZK paths. Also some of our HTTP APIs are file-system inspired (ConfigSet, FileStore, ...) with paths in which '/' is the separator no matter what the underlying file system is Solr is running on (after all; don't want the client to care about the OS Solr is running on). These are not *directly* convertible to a Path either, or at least take some work to do separator translation if the end location is on-disk (file store & file system ConfigSetService). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org