dsmiley commented on code in PR #2924:
URL: https://github.com/apache/solr/pull/2924#discussion_r1919163141
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -458,25 +458,25 @@ public void syncToAllNodes(String path) throws
IOException {
}
@Override
- public List<FileDetails> list(String path, Predicate<String> predicate) {
- File file = getRealpath(path).toFile();
+ public List<FileDetails> list(String path, Predicate<String> predicate)
throws IOException {
+ Path file = getRealpath(path);
Review Comment:
I strongly recommend the "rename" refactoring in your IDE. It's a memorized
hotkey for me -- renaming is something developers do often and IDEs have
sophisticated syntactical understanding. Find/replace is simple/dumb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
