psalagnac commented on PR #3036: URL: https://github.com/apache/solr/pull/3036#issuecomment-2596891316
> ZkStateReader.waitForState has the wait unit params immediately after the collection name. I think the new waitForState you added should be consistent. Keeping the functional arg at the end seems like better style as well. Not new but fair! I dislike parameter order since I've been looking at these methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org