[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2025-01-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912254#comment-17912254 ] Ishan Chattopadhyaya commented on SOLR-16825: - This commit might be responsib

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-12 Thread via GitHub
epugh commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912458457 ## solr/core/src/java/org/apache/solr/core/PluginInfo.java: ## @@ -100,39 +100,23 @@ public String toString() { } } + /** From XML. */ Review Comment: Maybe e

[jira] [Updated] (SOLR-17221) Http2SolrClient merges case sensitive solr params

2025-01-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17221: -- Labels: pull-request-available (was: ) > Http2SolrClient merges case sensitive solr params > -

[PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
831973741yy opened a new pull request, #3028: URL: https://github.com/apache/solr/pull/3028 https://issues.apache.org/jira/browse/SOLR-17221 # Description The Request object composed by Http2SolrClient via POST/PUT method merges case sensitive solr params. This is b

[jira] [Commented] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912283#comment-17912283 ] Ishan Chattopadhyaya commented on SOLR-17406: - This issue removed Eclipse IDE

[jira] [Commented] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912285#comment-17912285 ] Ishan Chattopadhyaya commented on SOLR-17406: - [~malliaridis] , simple revert

[jira] [Commented] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912284#comment-17912284 ] Ishan Chattopadhyaya commented on SOLR-17406: - As I re-read Christos' comment

Re: [PR] Payload Score Parser: expand documentation's pointing to Lucene javadocs [solr]

2025-01-12 Thread via GitHub
epugh commented on PR #2693: URL: https://github.com/apache/solr/pull/2693#issuecomment-2585747352 GOing to take one more stab at this one... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-12 Thread via GitHub
madrob commented on code in PR #3026: URL: https://github.com/apache/solr/pull/3026#discussion_r1912473651 ## solr/core/src/test/org/apache/solr/util/TimeOutTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[jira] [Commented] (SOLR-17221) Http2SolrClient merges case sensitive solr params

2025-01-12 Thread Yue Yu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912281#comment-17912281 ] Yue Yu commented on SOLR-17221: --- [~dsmiley] sure thing! here is the PR: [https://github.co

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-12 Thread via GitHub
epugh commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912457832 ## solr/solrj/src/java/org/apache/solr/common/ConfigNode.java: ## @@ -93,9 +107,16 @@ default String attr(String name) { return attributes().get(name); } - defaul

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-12 Thread via GitHub
epugh commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912458457 ## solr/core/src/java/org/apache/solr/core/PluginInfo.java: ## @@ -100,39 +100,23 @@ public String toString() { } } + /** From XML. */ Review Comment: Maybe e

Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-12 Thread via GitHub
sandbergja commented on code in PR #3026: URL: https://github.com/apache/solr/pull/3026#discussion_r1912501591 ## solr/core/src/test/org/apache/solr/util/TimeOutTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-12 Thread via GitHub
madrob commented on code in PR #3026: URL: https://github.com/apache/solr/pull/3026#discussion_r1912499016 ## solr/core/src/test/org/apache/solr/util/TimeOutTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-12 Thread via GitHub
sandbergja commented on code in PR #3026: URL: https://github.com/apache/solr/pull/3026#discussion_r1912491090 ## solr/core/src/test/org/apache/solr/util/TimeOutTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] SOLR-17618: Add unit tests for org.apache.solr.util.TimeOut [solr]

2025-01-12 Thread via GitHub
sandbergja commented on code in PR #3026: URL: https://github.com/apache/solr/pull/3026#discussion_r1912491073 ## solr/core/src/test/org/apache/solr/util/TimeOutTest.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribu

Re: [PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
831973741yy commented on code in PR #3028: URL: https://github.com/apache/solr/pull/3028#discussion_r1912637510 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -784,7 +784,7 @@ private Request fillContentStream( } } else {

Re: [PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
dsmiley commented on code in PR #3028: URL: https://github.com/apache/solr/pull/3028#discussion_r1912650870 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -784,7 +784,7 @@ private Request fillContentStream( } } else { // a

Re: [PR] Remove ingress and node-services during reconcile [solr-operator]

2025-01-12 Thread via GitHub
HoustonPutman commented on PR #674: URL: https://github.com/apache/solr-operator/pull/674#issuecomment-2586143084 Yes, we should definitely include this. I'll try to get it merged early this week -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-12 Thread via GitHub
dsmiley commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912653511 ## solr/solrj/src/java/org/apache/solr/common/ConfigNode.java: ## @@ -93,9 +107,16 @@ default String attr(String name) { return attributes().get(name); } - defa

Re: [PR] Move DOMUtil ConfigNode methods to ConfigNode, with some name changes. [solr]

2025-01-12 Thread via GitHub
dsmiley commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912653422 ## solr/core/src/java/org/apache/solr/core/PluginInfo.java: ## @@ -100,39 +100,23 @@ public String toString() { } } + /** From XML. */ Review Comment: This

Re: [PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
831973741yy commented on PR #3028: URL: https://github.com/apache/solr/pull/3028#issuecomment-2586024118 @dsmiley > Can you propose a short description that shall go in CHANGES.txt ? Basically, how might a user experience this bug? Case sensitive solr params does not work reliably

Re: [PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
831973741yy commented on code in PR #3028: URL: https://github.com/apache/solr/pull/3028#discussion_r1912584876 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java: ## Review Comment: correct. The other two prepare the requests that go throu

[jira] [Commented] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912314#comment-17912314 ] Christos Malliaridis commented on SOLR-17406: - [~ichattopadhyaya] so I had a

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Attachment: Screenshot 2025-01-13 012825.png > Introduce Gradle Version Catalogs >

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Attachment: Screenshot 2025-01-13 012825.png > Introduce Gradle Version Catalogs >

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Attachment: (was: Screenshot 2025-01-13 012825.png) > Introduce Gradle Version

[jira] [Created] (SOLR-17619) Generate CHANGELOG.md (formerly CHANGES.txt) via logchange

2025-01-12 Thread David Smiley (Jira)
David Smiley created SOLR-17619: --- Summary: Generate CHANGELOG.md (formerly CHANGES.txt) via logchange Key: SOLR-17619 URL: https://issues.apache.org/jira/browse/SOLR-17619 Project: Solr Issue T

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Attachment: Screenshot 2025-01-13 014721.png > Introduce Gradle Version Catalogs >

[jira] [Updated] (SOLR-17406) Introduce Gradle Version Catalogs

2025-01-12 Thread Christos Malliaridis (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Malliaridis updated SOLR-17406: Attachment: Screenshot 2025-01-13 014818.png > Introduce Gradle Version Catalogs >

Re: [PR] SOLR-17221: Http2SolrClient merges case sensitive solr params [solr]

2025-01-12 Thread via GitHub
dsmiley commented on code in PR #3028: URL: https://github.com/apache/solr/pull/3028#discussion_r1912565128 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java: ## Review Comment: I believe the only test changes needed are the ones you did h