epugh commented on code in PR #3027:
URL: https://github.com/apache/solr/pull/3027#discussion_r1912457832
##########
solr/solrj/src/java/org/apache/solr/common/ConfigNode.java:
##########
@@ -93,9 +107,16 @@ default String attr(String name) {
return attributes().get(name);
}
- default String requiredStrAttr(String name, Supplier<RuntimeException> err) {
+ /**
+ * Like {@link #attr(String)} but throws an error (incorporating {@code
missing_err}) if not
+ * found.
+ */
+ default String attrRequired(String name, String missing_err) {
Review Comment:
nit pick, but should this bee `missingErr`? Thanks for the docs..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
