dsmiley commented on code in PR #3028:
URL: https://github.com/apache/solr/pull/3028#discussion_r1912565128
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientTestBase.java:
##########
Review Comment:
I believe the only test changes needed are the ones you did here in this
file. The other two source files extend this one and thus will run the same
test code (right?).
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -784,7 +784,7 @@ private Request fillContentStream(
}
} else {
// application/x-www-form-urlencoded
- Fields fields = new Fields();
+ Fields fields = new Fields(true);
Iterator<String> iter = wparams.getParameterNamesIterator();
while (iter.hasNext()) {
Review Comment:
This whole else block could be replaced with something very close to this,
notwisthanding the annoying leading question mark to chop off of toQueryString:
```
req.body(new StringRequestContent("application/x-www-form-urlencoded",
wparams.toQueryString(), FALLBACK_CHARSET));
```
I suppose if there are no params then we don't even need to send a body.
WDYT @jdyer1 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
