epugh commented on code in PR #3027: URL: https://github.com/apache/solr/pull/3027#discussion_r1912458457
########## solr/core/src/java/org/apache/solr/core/PluginInfo.java: ########## @@ -100,39 +100,23 @@ public String toString() { } } + /** From XML. */ Review Comment: Maybe extend just a bit? From schema.xml? It made me look for a similar constructor that was `/** From JSON. */` further down... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org