dsmiley commented on code in PR #3028:
URL: https://github.com/apache/solr/pull/3028#discussion_r1912650870
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -784,7 +784,7 @@ private Request fillContentStream(
}
} else {
// application/x-www-form-urlencoded
- Fields fields = new Fields();
+ Fields fields = new Fields(true);
Iterator<String> iter = wparams.getParameterNamesIterator();
while (iter.hasNext()) {
Review Comment:
The current code here is longer and goes through a Fields intermediary
mapping. This is why I find SolrParams existing method toQueryString a
tempting substitute. I'm doubtful we'll change toQueryString's leading
question mark because it's not worth the disturbance on users for a triviality.
I think FALLBACK_CHARSET must be UTF8 always be design. It's not clear what
purpose this constant serves vs referencing UTF8 directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
