Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-11-20 Thread via GitHub
malliaridis commented on code in PR #2876: URL: https://github.com/apache/solr/pull/2876#discussion_r1848994558 ## gradle/libs.versions.toml: ## @@ -138,7 +139,7 @@ jayway-jsonpath = "2.9.0" jctools = "4.0.5" jersey = "3.1.9" # TODO Sync with jersey versions -jersey-container

[PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2024-11-20 Thread via GitHub
malliaridis opened a new pull request, #2881: URL: https://github.com/apache/solr/pull/2881 https://issues.apache.org/jira/browse/SOLR-16427 # Description With the [ClassInitializationDeadlock](https://errorprone.info/bugpattern/ClassInitializationDeadlock) rule error-prone ch

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-20 Thread via GitHub
AndreyBozhko commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2489578817 Thanks - it also seemed to me that the change is too minor to warrant a JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] SOLR-16427: Enable error-prone PatternMatchingInstanceof rule [solr]

2024-11-20 Thread via GitHub
malliaridis merged PR #2867: URL: https://github.com/apache/solr/pull/2867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[I] Pods begin to restart as soon as i enable auth [solr-operator]

2024-11-20 Thread via GitHub
VishwajeetPandeyy opened a new issue, #730: URL: https://github.com/apache/solr-operator/issues/730 solr pods begin to restart as soon as I enable auth And as soon as I disable it , they come back on `bin/solr auth enable -credentials admin:admin -type basicAuth -z "$ZK_HOST"`

[PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-20 Thread via GitHub
gerlowskija opened a new pull request, #2875: URL: https://github.com/apache/solr/pull/2875 https://issues.apache.org/jira/browse/SOLR-16781 # Description Solr offers a number of ways for users to add JARs and resources to their classpath, including: * solr.xml entries

[jira] [Created] (SOLR-17569) TestLBHttpSolrClient/LBHttp2SolrClientIntegrationTest unreproducible test failures

2024-11-20 Thread James Dyer (Jira)
James Dyer created SOLR-17569: - Summary: TestLBHttpSolrClient/LBHttp2SolrClientIntegrationTest unreproducible test failures Key: SOLR-17569 URL: https://issues.apache.org/jira/browse/SOLR-17569 Project:

[jira] [Commented] (SOLR-16427) Evaluate and fix errorprone rules

2024-11-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899873#comment-17899873 ] ASF subversion and git services commented on SOLR-16427: Commit b

Re: [PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-20 Thread via GitHub
ds-manzinger commented on PR #2873: URL: https://github.com/apache/solr/pull/2873#issuecomment-2486175531 https://github.com/apache/solr/pull/2874 This is the Pull Request against main branch -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2872: URL: https://github.com/apache/solr/pull/2872#issuecomment-2486084852 Finally! All the junit tests related to StreamTool are passing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] SOLR-17567: Revert unnecessary signature changes in CatStream [solr]

2024-11-20 Thread via GitHub
malliaridis closed pull request #2878: SOLR-17567: Revert unnecessary signature changes in CatStream URL: https://github.com/apache/solr/pull/2878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-11-20 Thread via GitHub
iamsanjay commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2488502894 `s3-repository` test cases started to failing as HandlerWrapper class not available anymore which was part of Jetty10 and now with Jetty12, it's part of ee8.nested. However, spring-boot

Re: [PR] SOLR-17567: Improve Stream CLI implementation [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2872: URL: https://github.com/apache/solr/pull/2872#issuecomment-2488539724 Okay, this I think is almost ready to merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] SOLR-17556: Examples should run with the standard & recommended Solr home and solr data dir [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2861: URL: https://github.com/apache/solr/pull/2861#issuecomment-2488570462 Feedback in corporated. When this is back ported we need to remember to remove the CREDENTIALS lookups ;-) -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Resolved] (SOLR-17504) CoreContainer calls UpdateHandler.commit

2024-11-20 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-17504. --- Fix Version/s: 9.8 Resolution: Fixed > CoreContainer calls UpdateHandler.commit >

Re: [PR] SOLR-17531: Use new unified GC options [solr]

2024-11-20 Thread via GitHub
malliaridis commented on PR #2815: URL: https://github.com/apache/solr/pull/2815#issuecomment-2488321304 > I think I prefer the GC being explicit instead of relying on whatever JDK value is the default. The logging cleanup configs look good, but I would keep the G1GC configs. I was t

[jira] [Commented] (SOLR-17567) Improve Stream CLI implementation

2024-11-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899725#comment-17899725 ] ASF subversion and git services commented on SOLR-17567: Commit 6

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2835: URL: https://github.com/apache/solr/pull/2835#issuecomment-2488589191 > So Kerberos Auth is going away with this. Be sure to highlight this in CHANGES.txt and in JIRA. To me, Hadoop-Auth is a forgettable implementation detail (I didn't know _really_ know what th

Re: [PR] SOLR-16781: Remove solrconfig.xml directives [solr]

2024-11-20 Thread via GitHub
epugh commented on PR #2875: URL: https://github.com/apache/solr/pull/2875#issuecomment-2488606888 @gerlowskija how do you want to handle https://github.com/apache/solr/pull/2861? Should it go in first, or after? -- This is an automated message from the Apache Git Service. To respond

[PR] SOLR-17571: Introduce dependabot [solr]

2024-11-20 Thread via GitHub
malliaridis opened a new pull request, #2880: URL: https://github.com/apache/solr/pull/2880 https://issues.apache.org/jira/browse/SOLR-17571 # Description With the introduction of Version catalogs we can make use of dependabot and replace our current bot. This allows us to run

[jira] [Updated] (SOLR-17571) Introduce dependabot

2024-11-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17571: -- Labels: pull-request-available (was: ) > Introduce dependabot > > >

Re: [PR] SOLR-17567: Revert unnecessary signature changes in CatStream [solr]

2024-11-20 Thread via GitHub
malliaridis commented on PR #2878: URL: https://github.com/apache/solr/pull/2878#issuecomment-2488520057 Closing this in favor to https://github.com/apache/solr/pull/2872. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-20 Thread via GitHub
malliaridis commented on code in PR #2880: URL: https://github.com/apache/solr/pull/2880#discussion_r1850666596 ## .github/workflows/gradle-precommit.yml: ## @@ -1,17 +1,80 @@ name: Gradle Precommit -on: +on: pull_request: branches: - 'main' - 'branch_*

Re: [PR] SOLR-17567: Fix auth issue in stream tests [solr]

2024-11-20 Thread via GitHub
malliaridis merged PR #2877: URL: https://github.com/apache/solr/pull/2877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-20 Thread via GitHub
janhoy commented on code in PR #2880: URL: https://github.com/apache/solr/pull/2880#discussion_r1850477067 ## .github/workflows/gradle-precommit.yml: ## @@ -1,17 +1,80 @@ name: Gradle Precommit -on: +on: pull_request: branches: - 'main' - 'branch_*'

Re: [PR] [WIP] Jetty12 + EE8 [solr]

2024-11-20 Thread via GitHub
risdenk commented on PR #2876: URL: https://github.com/apache/solr/pull/2876#issuecomment-2488602738 s3mock was a problem when I last looked at Jetty 11/12 due to it needing to stay on 2.x due to Java 17 required in 3.x. However, now that we are on JDK 17 on main, we should be able to upgra

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-11-20 Thread via GitHub
mkhludnev commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2488992810 > PR is only about custom metrics i.e. calculating a value for each bucket. It's not about creating custom faceting types for making buckets in the first place. does it mean `FacetP

[PR] SOLR-17306: fix replication problem on follower restart [solr]

2024-11-20 Thread via GitHub
ds-manzinger opened a new pull request, #2873: URL: https://github.com/apache/solr/pull/2873 https://issues.apache.org/jira/browse/SOLR-17306 # Description If Leader has Replication disabled - do not delete Followers data on restart # Solution Check if

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-20 Thread via GitHub
dsmiley commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1851435460 ## solr/modules/hadoop-auth/src/java/org/apache/solr/security/hadoop/KerberosPlugin.java: ## Review Comment: I assumed you were aware of what you were removing, but m

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-20 Thread via GitHub
malliaridis commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2489847298 The current configuration has multiple issues that I will fix in the upcoming changes. Are there any specific needs for how to treat security updates (dependencies with vulnerabilities)?

Re: [PR] SOLR-17540: Remove Hadoop Auth Module [solr]

2024-11-20 Thread via GitHub
dsmiley commented on code in PR #2835: URL: https://github.com/apache/solr/pull/2835#discussion_r1851435460 ## solr/modules/hadoop-auth/src/java/org/apache/solr/security/hadoop/KerberosPlugin.java: ## Review Comment: Perhaps you deleted the whole module without examining it