[ https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899725#comment-17899725 ]
ASF subversion and git services commented on SOLR-17567: -------------------------------------------------------- Commit 66a16805be3142705bcfdf22806d4c2b4720b1a1 in solr's branch refs/heads/main from Christos Malliaridis [ https://gitbox.apache.org/repos/asf?p=solr.git;h=66a16805be3 ] SOLR-17567: Fix auth issue in stream tests (#2877) * Fix auth issue in stream tests * Add negative test for missing auth > Improve Stream CLI implementation > --------------------------------- > > Key: SOLR-17567 > URL: https://issues.apache.org/jira/browse/SOLR-17567 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: cli > Reporter: Christos Malliaridis > Priority: Major > Labels: cli, pull-request-available, streams > Time Spent: 2h 10m > Remaining Estimate: 0h > > The current implemention for the CLI's Streams command that was introduced in > SOLR-14673 has multiple issues that should be addressed, including but not > limited to: > - Use of raw strings in {{Option#getOptionValue()}} > - Overlapping options ({{\-f}} and {{\-e}}) > - Multiple type suppressions that can be avoided > - A bug that causes specific bats tests to fail > - StreamTool.LocalCatStream overrides CatStream btu does not properly set > commaDelimitedFilepaths (this may be a bug) > - Obsolete LetStream#getLetParams() was introduced > - Function StreamTool.constructStream seems obsolete and occurrences can be > replaced with implementation > - Implementation of StreamTool.readExpression does not take leading spaces > infront of comment lines into account > - Implementation of StreamTool.readExpression does not support {{*/}} at the > end of line -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org