gerlowskija opened a new pull request, #2875: URL: https://github.com/apache/solr/pull/2875
https://issues.apache.org/jira/browse/SOLR-16781 # Description Solr offers a number of ways for users to add JARs and resources to their classpath, including: * solr.xml <sharedLib> entries * SOLR_MODULES env-var/support * core and install-level "lib/" directories * the package manager * direct classpath modification In addition to being largely redundant with the methods above, solrconfig.xml's <lib> directive has been a pain point and source of security concerns in the past. # Solution This commit removes <lib> references and support from 'main'. Most of the functional changes live in SolrConfig.java, where we now check for <lib> tags only to log out a warning about them being no longer supported. The remainder of the PR consists of updates to our ref-guide, to recommend other means of adding JARs to Solr's classpath. Most of these are for first-party modules, which can use the SOLR_MODULES system. # Tests Some modifications made to existing tests to ensure that <lib> tags no longer function (particularly TestConfigSetsAPI). # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
