malliaridis commented on PR #2815:
URL: https://github.com/apache/solr/pull/2815#issuecomment-2488321304

   > I think I prefer the GC being explicit instead of relying on whatever JDK 
value is the default. The logging cleanup configs look good, but I would keep 
the G1GC configs.
   
   I was thinking the same when I was editing it, thinking that if the defaults 
may change under certain circumstances, then we will not have a "reproducible" 
state. But for the same reason we would have to include all other defaults as 
well.
   
   I tried to understand why this was added in the first place, and it seemed 
to be some pre JDK 9 stuff, where G1GC was not the default GC and had to be 
configured explicitly. Since we had a lot of legacy JDK configuration, I 
decided to remove it during the cleanup. Not sure if there were other reasons 
though, as I never had to configure the JDK before (besides memory).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to