malliaridis opened a new pull request, #2881:
URL: https://github.com/apache/solr/pull/2881

   https://issues.apache.org/jira/browse/SOLR-16427
   
   # Description
   
   With the 
[ClassInitializationDeadlock](https://errorprone.info/bugpattern/ClassInitializationDeadlock)
 rule error-prone checks for possible class initialization deadlocks. See 
error-prone documentation for details about the problem this rule is fixing.
   
   # Solution
   
   Following the suggestions of error-prone, the possible deadlocks are 
resolved by introducing separate classes for constant fields.
   
   You can review commits individually for a better overview.
   
   This PR deprecates the classes in the old location and uses the new classes 
project-wide for partial backwards compatibility. This may break third-party / 
user code that reference the old classes. If we drop the need for backwards 
compatibility we can remove completely the deprecated classes and methods and 
solely update the CHANGES.txt by mentioning the new classes.
   
   - [ ] Update CHANGES.txt before merge
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch 
implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [X ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [X] I have developed this patch against the `main` branch.
   - [X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to