[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894141#comment-17894141
]
Jason Gerlowski commented on SOLR-17457:
I noticed we didn't have a CHANGES.txt e
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17464.
Fix Version/s: 9.7.1
Resolution: Fixed
> Http2SolrClient.requestAsync triggers NPE w
[
https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894145#comment-17894145
]
Jason Gerlowski commented on SOLR-17515:
bq. Why wasn't CHANGES.txt updated?
Ah,
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-17457:
---
Fix Version/s: 9.7.1
> StatusTool does not support --max-wait-secs
>
[
https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-17515.
Fix Version/s: 9.7.1
Resolution: Fixed
> Recovery fails in Solr 9.7.0 if basic-auth
gerlowskija commented on PR #2811:
URL: https://github.com/apache/solr/pull/2811#issuecomment-2446542011
Alright, taking this out of 'Draft' mode as it's complete and precommit and
tests both pass.
This PR should be able to go to both 'main' and 'branch_9x', and then we
should be abl
janhoy commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2446407361
> Instead of subclasses of LBSolrClient, ...Cloud...SolrClient,
...Http...ClusterStateProvider, we can have concrete impls that delegate to a
SolrClient that is provided. It's a vision an
[
https://issues.apache.org/jira/browse/SOLR-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894129#comment-17894129
]
ASF subversion and git services commented on SOLR-17464:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-17515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894130#comment-17894130
]
ASF subversion and git services commented on SOLR-17515:
Commit 8
epugh commented on PR #2809:
URL: https://github.com/apache/solr/pull/2809#issuecomment-2446787776
I would love to get a walk through on this exciting feature at the next
community meetup...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
epugh commented on code in PR #2809:
URL: https://github.com/apache/solr/pull/2809#discussion_r1822451338
##
solr/modules/llm/src/test/org/apache/solr/llm/TestLlmBase.java:
##
@@ -0,0 +1,297 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contri
jdyer1 commented on code in PR #2805:
URL: https://github.com/apache/solr/pull/2805#discussion_r1822683918
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientIntegrationTest.java:
##
@@ -337,8 +349,27 @@ public void startJetty() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-17457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894244#comment-17894244
]
Christos Malliaridis commented on SOLR-17457:
-
To be honest I paid little to
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2448299251
For some reason this PR breaks
`TestPullReplicaErrorHandling.testCloseHooksDeletedOnReconnect()` on a seed
that makes PRS enabled by default. From what I can tell there is an error in
`
HoustonPutman merged PR #131:
URL: https://github.com/apache/solr-site/pull/131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.
Christos Malliaridis created SOLR-17533:
---
Summary: Rearrange and cleanup solr.cmd
Key: SOLR-17533
URL: https://issues.apache.org/jira/browse/SOLR-17533
Project: Solr
Issue Type: Sub-tas
risdenk commented on PR #1995:
URL: https://github.com/apache/solr/pull/1995#issuecomment-2448096695
> @risdenk can this be closed? There is also #2804 for ECJ.
yup closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
risdenk commented on PR #1510:
URL: https://github.com/apache/solr/pull/1510#issuecomment-2448097572
Closing since main is on jdk 21 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk closed pull request #1510: WIP JDK 17
URL: https://github.com/apache/solr/pull/1510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
risdenk closed pull request #1505: WIP JDK 20
URL: https://github.com/apache/solr/pull/1505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
risdenk closed pull request #1995: WIP JDK 21
URL: https://github.com/apache/solr/pull/1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
risdenk commented on PR #1506:
URL: https://github.com/apache/solr/pull/1506#issuecomment-2448097782
Closing since main is on jdk 21 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
risdenk closed pull request #1506: WIP JDK 19
URL: https://github.com/apache/solr/pull/1506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
risdenk commented on PR #1505:
URL: https://github.com/apache/solr/pull/1505#issuecomment-2448097879
Closing since main is on jdk 21 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
malliaridis opened a new pull request, #2822:
URL: https://github.com/apache/solr/pull/2822
https://issues.apache.org/jira/browse/SOLR-17533
# Description
By rearranging the code we can allow the java classes to handle more of the
argument parsing and remove some more lines fro
[
https://issues.apache.org/jira/browse/SOLR-17533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17533:
--
Labels: cli pull-request-available (was: cli)
> Rearrange and cleanup solr.cmd
> -
risdenk closed pull request #1244: SOLR-5707: Lucene Expressions in Solr
URL: https://github.com/apache/solr/pull/1244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
[
https://issues.apache.org/jira/browse/SOLR-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-5707:
-
Labels: pull-request-available (was: )
> Lucene Expressions in Solr
> --
risdenk commented on PR #1244:
URL: https://github.com/apache/solr/pull/1244#issuecomment-2448124184
Not looking at this anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
epugh commented on PR #2819:
URL: https://github.com/apache/solr/pull/2819#issuecomment-2448125558
This ticket will also close https://issues.apache.org/jira/browse/SOLR-17409!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
[
https://issues.apache.org/jira/browse/SOLR-17469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894270#comment-17894270
]
Christos Malliaridis commented on SOLR-17469:
-
[~epugh] I have noticed there
dsmiley commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2447534533
Users generally don't refer to the LB client nor ClusterStateProvider; we
shouldn't constrain ourselves, especially in a major release.
I'll propose a dev list discussion on how users
dsmiley commented on code in PR #2805:
URL: https://github.com/apache/solr/pull/2805#discussion_r1823194257
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClientBase.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
malliaridis commented on code in PR #2819:
URL: https://github.com/apache/solr/pull/2819#discussion_r1822885781
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -260,7 +260,7 @@ protected void runExample(CommandLine cli, String
exampleName) throws Exception
dsmiley commented on code in PR #2811:
URL: https://github.com/apache/solr/pull/2811#discussion_r1823254387
##
solr/core/src/test/org/apache/solr/handler/TestUserManagedReplicationWithAuth.java:
##
@@ -227,26 +228,26 @@ private QueryResponse queryWithBasicAuth(SolrClient
client
malliaridis opened a new pull request, #2823:
URL: https://github.com/apache/solr/pull/2823
https://issues.apache.org/jira/browse/SOLR-17483
# Description
See https://github.com/apache/solr/pull/2816 for details.
Additionally, this PR also fixes a bug introduced in
78920
malliaridis merged PR #2816:
URL: https://github.com/apache/solr/pull/2816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894337#comment-17894337
]
ASF subversion and git services commented on SOLR-17483:
Commit c
[
https://issues.apache.org/jira/browse/SOLR-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17383:
--
Labels: pull-request-available (was: )
> CLI: Resolve overlapping arguments
>
iamsanjay merged PR #2797:
URL: https://github.com/apache/solr/pull/2797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
jdyer1 commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2447614530
I am torn about what to do about the lengthy doc-comment which was
copy/pasted from `LBHttpSolrClient` to `LBHttp2SolrClient`. I suppose the
right thing to do at this point is to copy/paste
anshumg merged PR #2803:
URL: https://github.com/apache/solr/pull/2803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2805:
URL: https://github.com/apache/solr/pull/2805#issuecomment-2448046838
> this is beyond the scope of this PR
I'm not sure I agree; it's *how* the issue is approached. Maybe there's a
sunk-cost issue here
--
This is an automated message from the Apach
malliaridis commented on PR #1995:
URL: https://github.com/apache/solr/pull/1995#issuecomment-2448082678
@risdenk can this be closed? There is also
https://github.com/apache/solr/pull/2804 for ECJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894315#comment-17894315
]
Houston Putman commented on SOLR-15556:
---
Thanks Jason!
> Ref Guide Redesign Phase
[
https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894162#comment-17894162
]
Jason Gerlowski commented on SOLR-15556:
Just wanted to leave a note here - I'm g
[
https://issues.apache.org/jira/browse/SOLR-17352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17352:
--
Labels: pull-request-available (was: )
> Remove deprecated commands from CLI, such as -zkHost.
epugh opened a new pull request, #2820:
URL: https://github.com/apache/solr/pull/2820
https://issues.apache.org/jira/browse/SOLR-17352
# Description
Time to remove options deprecated in 9x.
# Solution
Removing code! Trying to do it one by one by area.
# Tes
HoustonPutman commented on PR #760:
URL: https://github.com/apache/solr/pull/760#issuecomment-2448378316
Well apparently actually using PRS breaks a good amount of things
lovely. I'm going to undo that, and just add a `@NoPRS` tag to the test.
--
This is an automated message from the
epugh commented on code in PR #2822:
URL: https://github.com/apache/solr/pull/2822#discussion_r1823531429
##
solr/bin/solr.cmd:
##
@@ -429,21 +400,38 @@ IF "%1"=="-a" goto set_jvm_opts
IF "%1"=="--jvm-opts" goto set_jvm_opts
IF "%1"=="-j" goto set_addl_jetty_config
IF "%1"=="
malliaridis commented on code in PR #2820:
URL: https://github.com/apache/solr/pull/2820#discussion_r1823372644
##
solr/core/src/java/org/apache/solr/cli/ApiTool.java:
##
@@ -57,37 +56,19 @@ public List getOptions() {
.longOpt("solr-url")
.argName("URL"
epugh commented on PR #2819:
URL: https://github.com/apache/solr/pull/2819#issuecomment-2448585996
maybe just get this one in... honestly, i think
[SOLR-17409](https://issues.apache.org/jira/browse/SOLR-17409) may not be
needed if we are in a stable 9x place, since I want to focus on main
malliaridis commented on PR #2819:
URL: https://github.com/apache/solr/pull/2819#issuecomment-2448562671
> This ticket will also close
https://issues.apache.org/jira/browse/SOLR-17409!
I avoided applying it in other places as well to keep the changes to the
minimum. Should I do that
[
https://issues.apache.org/jira/browse/SOLR-17483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17483:
Status: Patch Available (was: Open)
> bin/solr.cmd run_zk method can be drasticall
[
https://issues.apache.org/jira/browse/SOLR-17531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christos Malliaridis updated SOLR-17531:
Status: Patch Available (was: Open)
> CLI: Optimize GC options
> -
malliaridis commented on PR #2819:
URL: https://github.com/apache/solr/pull/2819#issuecomment-2448665026
I was considering backporting this to `branch_9_7` but it seems a bit late
for fixing. @epugh what do you think? Changes are compatible.
--
This is an automated message from the Apache
malliaridis commented on code in PR #2822:
URL: https://github.com/apache/solr/pull/2822#discussion_r1823594086
##
solr/bin/solr.cmd:
##
@@ -429,21 +400,38 @@ IF "%1"=="-a" goto set_jvm_opts
IF "%1"=="--jvm-opts" goto set_jvm_opts
IF "%1"=="-j" goto set_addl_jetty_config
IF "
[
https://issues.apache.org/jira/browse/SOLR-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894364#comment-17894364
]
ASF subversion and git services commented on SOLR-16116:
Commit e
HoustonPutman merged PR #760:
URL: https://github.com/apache/solr/pull/760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
HoustonPutman opened a new pull request, #2824:
URL: https://github.com/apache/solr/pull/2824
Fixes issues with https://github.com/apache/solr/pull/2230, where
collections didn't have the PRS flag enabled when the default was enabled.
This does break tests, so it can't be merged witho
HoustonPutman commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2448411374
@noblepaul this doesn't actually make the collection PRS, instead it just
creates the collection in a PRS-way. I will make a PR that shows the tests that
break when PRS collections are
[
https://issues.apache.org/jira/browse/SOLR-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894359#comment-17894359
]
David Smiley commented on SOLR-17270:
-
Apparently a number of tests are flaky with PR
[
https://issues.apache.org/jira/browse/SOLR-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894370#comment-17894370
]
ASF subversion and git services commented on SOLR-17383:
Commit 4
malliaridis merged PR #2819:
URL: https://github.com/apache/solr/pull/2819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-17272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-17272.
---
Fix Version/s: main (10.0)
Resolution: Fixed
> PerReplicaState: Replica "state" and "leader" a
epugh commented on code in PR #2822:
URL: https://github.com/apache/solr/pull/2822#discussion_r1823531048
##
solr/bin/solr.cmd:
##
@@ -383,18 +355,19 @@ goto done
@echo.
goto done
-
-REM Really basic command-line arg parsing
+REM Parse arguments for special commands (start,
dsmiley commented on PR #2824:
URL: https://github.com/apache/solr/pull/2824#issuecomment-2448733108
So the change is to non-test code but it's actually about tests? Would it
be more accurate to say that there was a partial/broken attempt to make a
cluster-wide default for PRS but this PR
[
https://issues.apache.org/jira/browse/SOLR-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894383#comment-17894383
]
David Smiley commented on SOLR-17270:
-
This [JIRA
search|https://issues.apache.org/j
[
https://issues.apache.org/jira/browse/SOLR-17270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-17270:
Summary: Umbrella: Per Replica State (PRS) as default (was: Umbrella: Per
Replica State as default
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894429#comment-17894429
]
Sanjay Dutt commented on SOLR-17448:
Flaky org.apache.solr.cloud.TestAuthenticationF
[
https://issues.apache.org/jira/browse/SOLR-9323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894439#comment-17894439
]
David Smiley commented on SOLR-9323:
I don't think we need to expose a data structure
David Smiley created SOLR-17535:
---
Summary: Remove ClusterState.getCollectionStates() and
getCollectionsMap()
Key: SOLR-17535
URL: https://issues.apache.org/jira/browse/SOLR-17535
Project: Solr
iamsanjay commented on PR #2799:
URL: https://github.com/apache/solr/pull/2799#issuecomment-2449035569
FAILED: org.apache.solr.cloud.SplitShardTest.testWithChildDocuments
Test failing on branch_9x.
```
- org.apache.solr.cloud.SplitShardTest.testWithChildDocuments (:solr:co
dsmiley commented on PR #2799:
URL: https://github.com/apache/solr/pull/2799#issuecomment-2449093407
I understand the issue. the active cluster shape predicate differs from
master -> 9x; I handled one already on the backport by explicitly removing the
parent after the split but missed the
74 matches
Mail list logo
