malliaridis opened a new pull request, #2822:
URL: https://github.com/apache/solr/pull/2822

   https://issues.apache.org/jira/browse/SOLR-17533
   
   # Description
   
   By rearranging the code we can allow the java classes to handle more of the 
argument parsing and remove some more lines from `bin/solr.cmd`.
   
   # Solution
   
   This PR rearranges the code in a way that it is a more "top-to-bottom" flow 
without many up-and-down jumps via `goto`. Additionally, it gets rid of 
unnecessary statements and parsing and forwards all interactions to `SolrCLI` 
if it is not one of the commands `start`, `stop` or `restart`. This approach is 
followed in `bin/solr` as well.
   
   # Tests
   
   We are still lacking on tests for the `bin/solr.cmd` script. See 
[SOLR-17508](https://issues.apache.org/jira/browse/SOLR-17508).
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my 
code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended, not available for 
branches on forks living under an organisation)
   - [X] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to