malliaridis commented on code in PR #2822: URL: https://github.com/apache/solr/pull/2822#discussion_r1823594086
########## solr/bin/solr.cmd: ########## @@ -429,21 +400,38 @@ IF "%1"=="-a" goto set_jvm_opts IF "%1"=="--jvm-opts" goto set_jvm_opts IF "%1"=="-j" goto set_addl_jetty_config IF "%1"=="--jettyconfig" goto set_addl_jetty_config +IF "%1"=="--jetty-config" goto set_addl_jetty_config IF "%1"=="--noprompt" goto set_noprompt IF "%1"=="--no-prompt" goto set_noprompt + +REM Skip stop arg parsing if not stop command +IF NOT "%SCRIPT_CMD%"=="stop" goto parse_general_args + +:parse_stop_args IF "%1"=="-k" goto set_stop_key IF "%1"=="--key" goto set_stop_key IF "%1"=="--all" goto set_stop_all IF "%1"=="-all" goto set_stop_all + +:parse_general_args + +REM Print usage of command in case help option included +IF "%1"=="--help" goto usage +IF "%1"=="-help" goto usage +IF "%1"=="-h" goto usage +IF "%1"=="-usage" goto usage Review Comment: I'll wait for https://github.com/apache/solr/pull/2820 to be finished so that I can remove them safely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
