[ 
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17894429#comment-17894429
 ] 

Sanjay Dutt commented on SOLR-17448:
------------------------------------

 Flaky org.apache.solr.cloud.TestAuthenticationFramework.testBasics 
(:solr:core) 
{code:java}
    Test history: 
https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.cloud.TestAuthenticationFramework&tests.test=testBasics
 
http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.TestAuthenticationFramework.testBasics
    Test output: 
/home/jenkins/jenkins-slave/workspace/Solr/Solr-Check-9.x/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.TestAuthenticationFramework.txt
    Reproduce with: ./gradlew :solr:core:test --tests 
"org.apache.solr.cloud.TestAuthenticationFramework.testBasics" -Ptests.jvms=4 
-Ptests.haltonfailure=false "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 
-XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" 
-Ptests.seed=BFFF716399BC6DB0 -Ptests.multiplier=2 -Ptests.badapples=false 
-Ptests.file.encoding=UTF-8{code}

> Audit usage of ExecutorService#submit in Solr codebase
> ------------------------------------------------------
>
>                 Key: SOLR-17448
>                 URL: https://issues.apache.org/jira/browse/SOLR-17448
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 9.7
>            Reporter: Andrey Bozhko
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 9.8
>
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> There are quite a few places in Solr codebase where the background task is 
> created by invoking `ExecutorService#submit(...)` method - but where the 
> reference to the returned future is not retained.
> So if the background task fails for any reason, and the task doesn't itself 
> have a try-catch block to log the failure, - the failure will go completely 
> unnoticed.
>  
> This ticket is to review the usage of ExecutorService#submit method in the 
> codebase, and replace those with Executor#execute where appropriate.
>  
> Originally brought up in the dev mailing list: 
> [https://lists.apache.org/thread/5f1965rltcspgw0j8nzcn2qnz9l4s8qm]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to