[GitHub] [solr] cpoerschke commented on pull request #1950: SOLR-16994: facilitate date-related FieldValueFeature extensions (docValues=True only)

2023-09-29 Thread via GitHub
cpoerschke commented on PR #1950: URL: https://github.com/apache/solr/pull/1950#issuecomment-1740672315 Thanks @stillalex and @dsmiley for your feedback, both really resonated with me. I like `readNumericDocValuesDate` as a name, thanks for that suggestion! During development I'd used

[GitHub] [solr] cpoerschke commented on a diff in pull request #1958: [WIP] SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-29 Thread via GitHub
cpoerschke commented on code in PR #1958: URL: https://github.com/apache/solr/pull/1958#discussion_r1341234253 ## solr/core/src/java/org/apache/solr/search/DelegatingCollector.java: ## @@ -80,9 +80,20 @@ protected void doSetNextReader(LeafReaderContext context) throws IOExcepti

[GitHub] [solr] epugh commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-29 Thread via GitHub
epugh commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341456896 ## solr/core/src/test/org/apache/solr/cli/PackageToolTest.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [solr] epugh commented on pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

2023-09-29 Thread via GitHub
epugh commented on PR #1954: URL: https://github.com/apache/solr/pull/1954#issuecomment-1741013117 Okay, I'd love some review on this, I think it's more or less ready! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] AndreyBozhko commented on a diff in pull request #1961: Update indexing docs in Solr ref guide

2023-09-29 Thread via GitHub
AndreyBozhko commented on code in PR #1961: URL: https://github.com/apache/solr/pull/1961#discussion_r1341570013 ## solr/solr-ref-guide/modules/indexing-guide/pages/field-type-definitions-and-properties.adoc: ## @@ -201,7 +201,7 @@ The table below includes the default value for

[GitHub] [solr] stillalex commented on a diff in pull request #1958: [WIP] SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-29 Thread via GitHub
stillalex commented on code in PR #1958: URL: https://github.com/apache/solr/pull/1958#discussion_r1341572855 ## solr/core/src/java/org/apache/solr/search/DelegatingCollector.java: ## @@ -80,9 +80,20 @@ protected void doSetNextReader(LeafReaderContext context) throws IOExceptio

[GitHub] [solr] AndreyBozhko commented on a diff in pull request #1961: Update indexing docs in Solr ref guide

2023-09-29 Thread via GitHub
AndreyBozhko commented on code in PR #1961: URL: https://github.com/apache/solr/pull/1961#discussion_r1341570910 ## solr/solr-ref-guide/modules/indexing-guide/pages/schema-elements.adoc: ## @@ -95,18 +95,23 @@ However, `uniqueKey` will continue to work, as long as the field is

[jira] [Created] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-17004: --- Summary: ZkStateReader waitForState should check clusterState before using watchers Key: SOLR-17004 URL: https://issues.apache.org/jira/browse/SOLR-17004 Project: Solr

[jira] [Commented] (SOLR-13833) setupRequest normally called twice

2023-09-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770527#comment-17770527 ] Kevin Risden commented on SOLR-13833: - I created SOLR-17004 which helps improve setup

[GitHub] [solr] asfgit closed pull request #1842: SOLR-16644 Fixing the entropy warning threshold based on OS ubuntu an…

2023-09-29 Thread via GitHub
asfgit closed pull request #1842: SOLR-16644 Fixing the entropy warning threshold based on OS ubuntu an… URL: https://github.com/apache/solr/pull/1842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770531#comment-17770531 ] ASF subversion and git services commented on SOLR-16644: Commit d

[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770530#comment-17770530 ] ASF subversion and git services commented on SOLR-16644: Commit 0

[jira] [Commented] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770528#comment-17770528 ] Kevin Risden commented on SOLR-17004: - PR - https://github.com/apache/solr/pull/1945

[GitHub] [solr] risdenk commented on a diff in pull request #1945: SOLR-17004: ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread via GitHub
risdenk commented on code in PR #1945: URL: https://github.com/apache/solr/pull/1945#discussion_r1341636978 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1802,6 +1800,18 @@ public void waitForState( throw new AlreadyClosedExcepti

[GitHub] [solr] chatman commented on pull request #1842: SOLR-16644 Fixing the entropy warning threshold based on OS ubuntu an…

2023-09-29 Thread via GitHub
chatman commented on PR #1842: URL: https://github.com/apache/solr/pull/1842#issuecomment-1741256414 Thanks @elyograg! I think I was able to fix this before the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [solr] risdenk commented on pull request #1945: SOLR-17004: ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread via GitHub
risdenk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1741253060 I moved this over to https://issues.apache.org/jira/browse/SOLR-17004 since it really didn't change setupRequest at all. -- This is an automated message from the Apache Git Service. To res

[jira] [Updated] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17004: Status: Patch Available (was: Open) > ZkStateReader waitForState should check clusterState before

[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770532#comment-17770532 ] ASF subversion and git services commented on SOLR-16644: Commit 9

[GitHub] [solr] risdenk commented on pull request #1945: SOLR-17004: ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread via GitHub
risdenk commented on PR #1945: URL: https://github.com/apache/solr/pull/1945#issuecomment-1741256726 I put changes on main for now. I plan on merging this once tests pass again locally. I'll let it sit on main for a few days then look at backporting. Not sure it will make 9.4. -- This is

[jira] [Commented] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770534#comment-17770534 ] ASF subversion and git services commented on SOLR-16644: Commit 4

[jira] [Resolved] (SOLR-16644) Entropy warning thresholds need to be revisited

2023-09-29 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-16644. - Fix Version/s: 9.4 Resolution: Fixed Thanks [~raghavanm]! > Entropy warni

[GitHub] [solr] risdenk merged pull request #1945: SOLR-17004: ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread via GitHub
risdenk merged PR #1945: URL: https://github.com/apache/solr/pull/1945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17004: Fix Version/s: main (10.0) > ZkStateReader waitForState should check clusterState before using watc

[jira] [Commented] (SOLR-17004) ZkStateReader waitForState should check clusterState before using watchers

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770549#comment-17770549 ] ASF subversion and git services commented on SOLR-17004: Commit 2

[GitHub] [solr] dsmiley commented on pull request #1962: Coordinator node does not have correct collection tagged for TracingSpan

2023-09-29 Thread via GitHub
dsmiley commented on PR #1962: URL: https://github.com/apache/solr/pull/1962#issuecomment-1741319452 Also, please create branches for PRs on your own fork so as to not pollute the upstream branch namespace. I've made this mistake before too; not a huge deal. -- This is an automated mess

[GitHub] [solr] magibney opened a new pull request, #1964: SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation

2023-09-29 Thread via GitHub
magibney opened a new pull request, #1964: URL: https://github.com/apache/solr/pull/1964 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [solr] magibney commented on a diff in pull request #1964: SOLR-11535: Fix race condition in singleton-per-collection StateWatcher creation

2023-09-29 Thread via GitHub
magibney commented on code in PR #1964: URL: https://github.com/apache/solr/pull/1964#discussion_r1341703136 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1329,8 +1336,9 @@ public void process(WatchedEvent event) { return;

[GitHub] [solr] stillalex commented on a diff in pull request #1958: SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-29 Thread via GitHub
stillalex commented on code in PR #1958: URL: https://github.com/apache/solr/pull/1958#discussion_r1341707772 ## solr/core/src/java/org/apache/solr/search/DelegatingCollector.java: ## @@ -80,9 +80,20 @@ protected void doSetNextReader(LeafReaderContext context) throws IOExceptio

[jira] [Updated] (SOLR-16985) Upgrade Lucene to 9.8.0

2023-09-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-16985: Description: Apache Lucene 9.8.0 was recently released: https://lucene.apache.org/core/9_8_0/chang

[jira] [Commented] (SOLR-11535) Weird behavior of CollectionStateWatcher

2023-09-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770574#comment-17770574 ] Michael Gibney commented on SOLR-11535: --- This is still a problem! This issue was fi

[jira] [Assigned] (SOLR-11535) Weird behavior of CollectionStateWatcher

2023-09-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-11535: - Assignee: Michael Gibney > Weird behavior of CollectionStateWatcher > --

[jira] [Comment Edited] (SOLR-11535) Weird behavior of CollectionStateWatcher

2023-09-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770574#comment-17770574 ] Michael Gibney edited comment on SOLR-11535 at 9/29/23 7:09 PM: ---

[jira] [Assigned] (SOLR-16965) Issues when uploading stopwords

2023-09-29 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya reassigned SOLR-16965: --- Assignee: Ishan Chattopadhyaya > Issues when uploading stopwords > -

[jira] [Commented] (SOLR-16965) Issues when uploading stopwords

2023-09-29 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770583#comment-17770583 ] Ishan Chattopadhyaya commented on SOLR-16965: - Seems like a legitimate issue

[jira] [Comment Edited] (SOLR-11535) Weird behavior of CollectionStateWatcher

2023-09-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770574#comment-17770574 ] Michael Gibney edited comment on SOLR-11535 at 9/29/23 8:29 PM: ---

[GitHub] [solr] julia-maimone opened a new pull request, #1965: SOLR-16924: Refactor requestApplyUpdate step in action=RESTORE

2023-09-29 Thread via GitHub
julia-maimone opened a new pull request, #1965: URL: https://github.com/apache/solr/pull/1965 https://issues.apache.org/jira/browse/SOLR-16924 # Description Refactor action=RESTORE to transition UpdateLog to ACTIVE after each replica is restored in RestoreCore call, instead of

[GitHub] [solr] janhoy merged pull request #1963: Fix the admin UI green core-size graph on nodes screen

2023-09-29 Thread via GitHub
janhoy merged PR #1963: URL: https://github.com/apache/solr/pull/1963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] dsmiley commented on a diff in pull request #1739: SOLR-16852: Let backups have custom key/values

2023-09-29 Thread via GitHub
dsmiley commented on code in PR #1739: URL: https://github.com/apache/solr/pull/1739#discussion_r1341874503 ## solr/core/src/java/org/apache/solr/core/backup/BackupProperties.java: ## @@ -93,10 +108,25 @@ public static BackupProperties readFrom( repository.openI

[GitHub] [solr] dsmiley commented on a diff in pull request #1965: SOLR-16924: Refactor requestApplyUpdate step in action=RESTORE

2023-09-29 Thread via GitHub
dsmiley commented on code in PR #1965: URL: https://github.com/apache/solr/pull/1965#discussion_r1341882448 ## solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCoreAPI.java: ## @@ -146,6 +147,10 @@ private void doRestore(String coreName, RestoreCoreRequestBody reques

[GitHub] [solr] stillalex merged pull request #1958: SOLR-16985 Upgrade Lucene to 9.8.0

2023-09-29 Thread via GitHub
stillalex merged PR #1958: URL: https://github.com/apache/solr/pull/1958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-16985) Upgrade Lucene to 9.8.0

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770638#comment-17770638 ] ASF subversion and git services commented on SOLR-16985: Commit 8

[jira] [Resolved] (SOLR-16985) Upgrade Lucene to 9.8.0

2023-09-29 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu resolved SOLR-16985. - Resolution: Fixed > Upgrade Lucene to 9.8.0 > --- > > Key: SO

[jira] [Commented] (SOLR-16985) Upgrade Lucene to 9.8.0

2023-09-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770639#comment-17770639 ] ASF subversion and git services commented on SOLR-16985: Commit a

[GitHub] [solr] dsmiley commented on a diff in pull request #1960: SOLR-16825: Migrate v2 definitions to 'api' module, pt 4

2023-09-29 Thread via GitHub
dsmiley commented on code in PR #1960: URL: https://github.com/apache/solr/pull/1960#discussion_r1341831218 ## solr/api/src/java/org/apache/solr/client/api/model/CreateCollectionRequestBody.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (SOLR-11535) Weird behavior of CollectionStateWatcher

2023-09-29 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770644#comment-17770644 ] Michael Gibney commented on SOLR-11535: --- This issue is not purely academic -- it ca

[jira] [Created] (SOLR-17005) Running bin\solr.cmd fails with "-Xss256k was unexpected at this time"

2023-09-29 Thread Shawn Heisey (Jira)
Shawn Heisey created SOLR-17005: --- Summary: Running bin\solr.cmd fails with "-Xss256k was unexpected at this time" Key: SOLR-17005 URL: https://issues.apache.org/jira/browse/SOLR-17005 Project: Solr

[jira] [Commented] (SOLR-17005) Running bin\solr.cmd fails with "-Xss256k was unexpected at this time"

2023-09-29 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770647#comment-17770647 ] Shawn Heisey commented on SOLR-17005: - I tried debugging it with added echo commands

[jira] [Updated] (SOLR-17005) Running 'bin\solr.cmd start' fails with "-Xss256k was unexpected at this time"

2023-09-29 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-17005: Summary: Running 'bin\solr.cmd start' fails with "-Xss256k was unexpected at this time" (was: Runn