julia-maimone opened a new pull request, #1965:
URL: https://github.com/apache/solr/pull/1965

   https://issues.apache.org/jira/browse/SOLR-16924
   
   # Description
   
   Refactor action=RESTORE to transition UpdateLog to ACTIVE after each replica 
is restored in RestoreCore call, instead of making calls to RequestApplyUpdate 
(which effectively transitions UpdateLog to ACTIVE state) on each newly 
restored replica.
   The purpose of this is to simplify and clarify steps of restore. The 
RequestApplyUpdate op not only buffers updates, it also transitions state (the 
only part necessary post restoring replica). 
   
   # Solution
   
   Remove calls to RequestApplyUpdate operation on each newly restored replica, 
and instead complete transition of UpdateLog to ACTIVE state in each 
RestoreCore op after data is restored to replica.
   
   # Tests
   
   Have run all existing unit tests in solr core module. 
   This is a refactor, existing tests for Backup/Restore are sufficient.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ X] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `main` branch.
   - [ X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to