cpoerschke commented on PR #1950: URL: https://github.com/apache/solr/pull/1950#issuecomment-1740672315
Thanks @stillalex and @dsmiley for your feedback, both really resonated with me. I like `readNumericDocValuesDate` as a name, thanks for that suggestion! During development I'd used `longToLong` as a temporary name (obviously can't use that for real) and wondered back and forth about making or not making it specific to the `NumberType.DATE` scenario. I saw a few challenges with a more generic approach: * how to convey that for non-float and non-double doc value types the post-processing is available but for float and double doc value types it is not available? * how to convey that for non doc value types the post-processing in not available? or how to make it available? * if making post-processing available more widely, is there a use case for it and how to avoid confusion with the normalisation that can be used at the model level? -- https://solr.apache.org/guide/solr/latest/query-guide/learning-to-rank.html#normalizer So having _doc values_ and _date_ in the name, somehow, addresses those challenges and also leaves the door open for `readNumericDocValues[Float,Double,...]` additions in future if there's a use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
