stillalex commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1341707772
##########
solr/core/src/java/org/apache/solr/search/DelegatingCollector.java:
##########
@@ -80,9 +80,20 @@ protected void doSetNextReader(LeafReaderContext context)
throws IOException {
leafDelegate = delegate.getLeafCollector(context);
}
- public void finish() throws IOException {
+ /**
+ * From Solr 9.4 using Lucene 9.8 onwards
<code>DelegatingCollector.finish</code> clashes with the
+ * super class's <code>LeafCollector.finish</code> method. Please relocate
any finishing logic
+ * into the <code>DelegatingCollector.complete</code> replacement completion
method.
+ */
+ @Override
+ public final void finish() throws IOException {
+ super.finish();
+ }
Review Comment:
turns out there was a leafCollector finish call missing here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
