dsmiley commented on code in PR #1965:
URL: https://github.com/apache/solr/pull/1965#discussion_r1341882448


##########
solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCoreAPI.java:
##########
@@ -146,6 +147,10 @@ private void doRestore(String coreName, 
RestoreCoreRequestBody requestBody) thro
           .getZkController()
           .getShardTerms(cd.getCollectionName(), cd.getShardId())
           .ensureHighestTermsAreNotZero();
+
+      // transitions state of update log to ACTIVE
+      UpdateLog updateLog = core.getUpdateHandler().getUpdateLog();
+      updateLog.applyBufferedUpdates();

Review Comment:
   I'd add a null check on this updateLog just in case there is none.  In 
practice it's always there for SolrCloud but there are lots of null checks 
elsewhere for it and I like to think we could run SolrCloud without insisting 
on it (albeit expert).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to