[GitHub] [solr-operator] a-nych commented on a diff in pull request #520: Use correct user for chmod command in cp-solr-xml init container

a-nych commented on code in PR #520: URL: https://github.com/apache/solr-operator/pull/520#discussion_r1169605511 ## controllers/controller_utils_test.go: ## @@ -906,11 +906,13 @@ var ( } one= int64(1) two= int64(2)

[GitHub] [solr] ilariapet commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

ilariapet commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169643395 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(ResultContex

[jira] [Created] (SOLR-16752) Reduce attack surface and size for Docker image

Cuong Bui created SOLR-16752: Summary: Reduce attack surface and size for Docker image Key: SOLR-16752 URL: https://issues.apache.org/jira/browse/SOLR-16752 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-16752) Reduce attack surface and size for Docker image

[ https://issues.apache.org/jira/browse/SOLR-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cuong Bui updated SOLR-16752: - Description: Hi, I have created this issue here as a replacement for the pull request on GitHub: https:

[GitHub] [solr-operator] janhoy opened a new issue, #556: Expose k8s topology labels to Solr PODs

janhoy opened a new issue, #556: URL: https://github.com/apache/solr-operator/issues/556 We support topologySpreadConstraint in #350, so Solr PODs are spread across AZs. But for Solr to be able to place replicas across AZs with the [Affinity placement plugin](https://solr.apache.org/guide/

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169839350 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(Re

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169839350 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(Re

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169843711 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(Re

[GitHub] [solr] ilariapet commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

ilariapet commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169863438 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(ResultContex

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169868929 ## solr/CHANGES.txt: ## @@ -85,7 +85,9 @@ Improvements `GET /api/node/logging/messages`. And the threshold for the log "listener" can be modified with

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169872799 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(Re

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169886237 ## solr/modules/ltr/src/test/org/apache/solr/ltr/feature/TestFeatureLogging.java: ## @@ -152,6 +152,74 @@ public void testDefaultStoreFeatureExtraction() throw

[jira] [Commented] (SOLR-16711) Seperate tools out of SolrCLI.java into their own files.

[ https://issues.apache.org/jira/browse/SOLR-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713555#comment-17713555 ] Eric Pugh commented on SOLR-16711: -- PR is ready for review, all the tests pass.. I'd l

[jira] [Commented] (SOLR-16752) Reduce attack surface and size for Docker image

[ https://issues.apache.org/jira/browse/SOLR-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713557#comment-17713557 ] Jan Høydahl commented on SOLR-16752: You can make a PR against the Dockerfile templat

[GitHub] [solr] ilariapet commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

ilariapet commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169916567 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(ResultContex

[GitHub] [solr] ilariapet commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

ilariapet commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169918755 ## solr/CHANGES.txt: ## @@ -85,7 +85,9 @@ Improvements `GET /api/node/logging/messages`. And the threshold for the log "listener" can be modified with `PUT /api/

[GitHub] [solr] renatoh commented on pull request #1570: Move duplicated code to method in TaskManagementHandler.java

renatoh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1513014295 @epugh Thanks for the feedback. Is there an Intellij Code Style Scheme I can use in order to format the code correctly right within Intellij? -- This is an automated message from the Apach

[GitHub] [solr] epugh commented on pull request #1570: Move duplicated code to method in TaskManagementHandler.java

epugh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1513018116 Good questions @renatoh.. I am not possiitve, however if you run `gradlew tidy` then it applies our spotless code formatter -- This is an automated message from the Apache Git Service.

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

alessandrobenedetti commented on code in PR #1487: URL: https://github.com/apache/solr/pull/1487#discussion_r1169981475 ## solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java: ## @@ -241,10 +242,31 @@ public void setContext(Re

[GitHub] [solr] alessandrobenedetti commented on pull request #1471: [SOLR-15737]: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)

alessandrobenedetti commented on PR #1471: URL: https://github.com/apache/solr/pull/1471#issuecomment-1513079272 Is there any problem with the CHANGES.txt? I see some broken checks here, and a contribution from a colleague of mine seems to have a broken crave build caused by the CHANGES.t

[jira] [Commented] (SOLR-16751) ClusterState.collectionFromObjects() stores copy of shards in DocCollection.getProperties()

[ https://issues.apache.org/jira/browse/SOLR-16751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713579#comment-17713579 ] Noble Paul commented on SOLR-16751: --- this fix is correct. Thanks [~hossman] > ClusterS

[GitHub] [solr-operator] AlessandroPerucchi commented on issue #414: How to load solrconfig.xml from configmap

AlessandroPerucchi commented on issue #414: URL: https://github.com/apache/solr-operator/issues/414#issuecomment-1513123711 @HoustonPutman Hi, Thank you for the feedback too, I was interested also to do it. I've tried the config API, but... I could not change the following option:

[GitHub] [solr] renatoh commented on pull request #1570: Move duplicated code to method in TaskManagementHandler.java

renatoh commented on PR #1570: URL: https://github.com/apache/solr/pull/1570#issuecomment-1513205591 @epugh so what tool is used within gradlew tidy to format the code? I am wondering it is possible to load these code style rules into a Intellij Code Style schema I ran tidy and pus

[GitHub] [solr-operator] HoustonPutman commented on issue #414: How to load solrconfig.xml from configmap

HoustonPutman commented on issue #414: URL: https://github.com/apache/solr-operator/issues/414#issuecomment-1513215464 Probably not unfortunately. You can instead use the **configSet api** to make a fully new configSet for yourself instead of just updating one value. However in future

[GitHub] [solr-operator] HoustonPutman commented on issue #556: Expose k8s topology labels to Solr PODs

HoustonPutman commented on issue #556: URL: https://github.com/apache/solr-operator/issues/556#issuecomment-1513235127 Hey Jan, did you see this ancient PR https://github.com/apache/solr-operator/pull/90? Its basically hacking the node labels in as sysprops. But yes, you need node permissio

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #520: Use correct user for chmod command in cp-solr-xml init container

HoustonPutman commented on code in PR #520: URL: https://github.com/apache/solr-operator/pull/520#discussion_r1170106387 ## controllers/controller_utils_test.go: ## @@ -906,11 +906,13 @@ var ( } one= int64(1) two= i

[jira] [Commented] (SOLR-16746) Migrate How to Contribute content out of Confluence

[ https://issues.apache.org/jira/browse/SOLR-16746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713606#comment-17713606 ] ASF subversion and git services commented on SOLR-16746: Commit b

[GitHub] [solr-operator] HoustonPutman commented on issue #534: Ability to add additional volumes to Zookeeper Pods

HoustonPutman commented on issue #534: URL: https://github.com/apache/solr-operator/issues/534#issuecomment-1513270866 This is going to be handled in https://github.com/apache/solr-operator/issues/557 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr-operator] HoustonPutman closed issue #534: Ability to add additional volumes to Zookeeper Pods

HoustonPutman closed issue #534: Ability to add additional volumes to Zookeeper Pods URL: https://github.com/apache/solr-operator/issues/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [solr-operator] HoustonPutman opened a new issue, #557: Add in unsupported ZookeeperCluster options

HoustonPutman opened a new issue, #557: URL: https://github.com/apache/solr-operator/issues/557 These include things like: - `pod.topologySpreadConstraints` - `maxUnavailableReplicas` - `volumes` & `volumeMounts` - `containers` & `initContainers` - `adminServerService`, `cl

[GitHub] [solr-operator] janhoy commented on issue #556: Expose k8s topology labels to Solr PODs

janhoy commented on issue #556: URL: https://github.com/apache/solr-operator/issues/556#issuecomment-1513514614 Thanks for the link, did not find it. While a KubePropertiesPlugin is nice long term for several things, I think it makes sense to start with the more targeted feature of pr

[GitHub] [solr] Codearella opened a new pull request, #1574: Update external-files-processes.adoc

Codearella opened a new pull request, #1574: URL: https://github.com/apache/solr/pull/1574 I don't think these were supposed to have an underscore at the end - it appears to be a typo. (external_fieldname_ should be external_fieldname) https://issues.apache.org/jira/browse/SOLR-X

[GitHub] [solr] HoustonPutman merged pull request #1574: Fix filename in external-files-processes.adoc

HoustonPutman merged PR #1574: URL: https://github.com/apache/solr/pull/1574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

[GitHub] [solr-operator] HoustonPutman commented on pull request #520: Use correct user for chmod command in cp-solr-xml init container

HoustonPutman commented on PR #520: URL: https://github.com/apache/solr-operator/pull/520#issuecomment-1513553585 Had to include some fixes for https://github.com/apache/solr-operator/pull/548 and https://github.com/apache/solr-operator/issues/537 since the E2E tests wouldn't work without

[jira] [Commented] (SOLR-16750) Grouping on EnumFieldType fields fails

[ https://issues.apache.org/jira/browse/SOLR-16750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713695#comment-17713695 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16750: -- I'm probably

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #558: Add currently unsupported ZookeeperCluster options

HoustonPutman opened a new pull request, #558: URL: https://github.com/apache/solr-operator/pull/558 Resolves #557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[jira] [Commented] (SOLR-16751) ClusterState.collectionFromObjects() stores copy of shards in DocCollection.getProperties()

[ https://issues.apache.org/jira/browse/SOLR-16751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713706#comment-17713706 ] ASF subversion and git services commented on SOLR-16751: Commit 5

[jira] [Commented] (SOLR-16751) ClusterState.collectionFromObjects() stores copy of shards in DocCollection.getProperties()

[ https://issues.apache.org/jira/browse/SOLR-16751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713712#comment-17713712 ] ASF subversion and git services commented on SOLR-16751: Commit 3

[jira] [Resolved] (SOLR-16751) ClusterState.collectionFromObjects() stores copy of shards in DocCollection.getProperties()

[ https://issues.apache.org/jira/browse/SOLR-16751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-16751. --- Fix Version/s: main (10.0) 9.3 Assignee: Chris M. Hostette

[jira] [Created] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

Chris M. Hostetter created SOLR-16753: - Summary: SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures Key: SOLR-16753 URL: https://issues.apache.org/jira/browse/SOLR-16753 Proje

[jira] [Updated] (SOLR-16753) SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull failures

[ https://issues.apache.org/jira/browse/SOLR-16753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-16753: -- Attachment: SOLR-16753.txt Status: Open (was: Open) I'm attaching a log file f

[jira] [Created] (SOLR-16754) Move the info feedback into a tool....

Eric Pugh created SOLR-16754: Summary: Move the info feedback into a tool Key: SOLR-16754 URL: https://issues.apache.org/jira/browse/SOLR-16754 Project: Solr Issue Type: Sub-task Co

[jira] [Created] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

Chris M. Hostetter created SOLR-16755: - Summary: bin/solr's '-noprompt' option no longer works for examples Key: SOLR-16755 URL: https://issues.apache.org/jira/browse/SOLR-16755 Project: Solr

[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713774#comment-17713774 ] Chris M. Hostetter commented on SOLR-16755: --- I consider myself a competent shel

[jira] [Commented] (SOLR-16755) bin/solr's '-noprompt' option no longer works for examples

[ https://issues.apache.org/jira/browse/SOLR-16755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713783#comment-17713783 ] Chris M. Hostetter commented on SOLR-16755: --- Ah ... ok, here's the culprit... {

[GitHub] [solr] bqcuong opened a new pull request, #1575: SOLR-16752 Reduce attack surface and size for Docker image

bqcuong opened a new pull request, #1575: URL: https://github.com/apache/solr/pull/1575 https://issues.apache.org/jira/browse/SOLR-16752 # Description The Dockerfiles should contain the `--no-install-recommends` option wherever there is an `apt-get install` command. This sh

[GitHub] [solr] janhoy commented on pull request #1575: SOLR-16752 Reduce attack surface and size for Docker image

janhoy commented on PR #1575: URL: https://github.com/apache/solr/pull/1575#issuecomment-1514212470 Thanks. Did you consider patching the apt-get command in the header template too? It only installs wget (gpg is removed in same RUN) so not sure if there is any difference. -- This is an a

[GitHub] [solr] noblepaul commented on pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

noblepaul commented on PR #1477: URL: https://github.com/apache/solr/pull/1477#issuecomment-1514223539 > ping @noblepaul do u have a chance to take a look? Please lemme know if u have any questions/concerns. thanks again! @patsonluk I had posted my comments above -- This is an