alessandrobenedetti commented on code in PR #1487:
URL: https://github.com/apache/solr/pull/1487#discussion_r1169839350
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -241,10 +242,31 @@ public void setContext(ResultContext context) {
*
* @param transformerFeatureStore the explicit transformer feature store
*/
- private LoggingModel createLoggingModel(String transformerFeatureStore) {
- final ManagedFeatureStore fr =
ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+ private LoggingModel createLoggingModel(
+ String transformerFeatureStore, Boolean docsWereNotReranked) {
+ final ManagedFeatureStore featureStore =
+ ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+
+ // check for non-existent feature store name
+ if (transformerFeatureStore != null) {
+ if (!featureStore.getStores().containsKey(transformerFeatureStore)) {
Review Comment:
mmmm what is the difference with:
`public synchronized FeatureStore getFeatureStore(String name) {
if (name == null) {
name = FeatureStore.DEFAULT_FEATURE_STORE_NAME;
@@ -160,11 +164,12 @@ public void doGet(BaseSolrResource endpoint, String
childId) {
if (childId == null) {
response.add(FEATURE_STORE_JSON_FIELD, stores.keySet());
} else {
// check for non-existent feature store name
if (!stores.containsKey(childId)) {
throw new SolrException(
SolrException.ErrorCode.BAD_REQUEST, "Missing feature store: "
+ childId);
}` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
