ilariapet commented on code in PR #1487:
URL: https://github.com/apache/solr/pull/1487#discussion_r1169643395
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -241,10 +242,31 @@ public void setContext(ResultContext context) {
*
* @param transformerFeatureStore the explicit transformer feature store
*/
- private LoggingModel createLoggingModel(String transformerFeatureStore) {
- final ManagedFeatureStore fr =
ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+ private LoggingModel createLoggingModel(
+ String transformerFeatureStore, Boolean docsWereNotReranked) {
+ final ManagedFeatureStore featureStore =
+ ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+
+ // check for non-existent feature store name
+ if (transformerFeatureStore != null) {
+ if (!featureStore.getStores().containsKey(transformerFeatureStore)) {
Review Comment:
When a nonexistent feature store is passed with _"final FeatureStore store =
featureStore.getFeatureStore(transformerFeatureStore);"_ no error is received
and the store is improperly added (empty) to the list of feature stores. In
fact, the getFeatureStore() method is also used for the 'put' phase.
So a check was added to get the error and avoid creating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
