[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1487: SOLR-15493: Throw an error message if the feature store doesn't exist

[via GitHub]

alessandrobenedetti commented on code in PR #1487:
URL: https://github.com/apache/solr/pull/1487#discussion_r1169872799


##########
solr/modules/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java:
##########
@@ -241,10 +242,31 @@ public void setContext(ResultContext context) {
      *
      * @param transformerFeatureStore the explicit transformer feature store
      */
-    private LoggingModel createLoggingModel(String transformerFeatureStore) {
-      final ManagedFeatureStore fr = 
ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+    private LoggingModel createLoggingModel(
+        String transformerFeatureStore, Boolean docsWereNotReranked) {
+      final ManagedFeatureStore featureStores =
+          ManagedFeatureStore.getManagedFeatureStore(req.getCore());
+
+      // check for non-existent feature store name
+      if (transformerFeatureStore != null) {
+        if (!featureStores.getStores().containsKey(transformerFeatureStore)) {
+          throw new SolrException(
+              SolrException.ErrorCode.BAD_REQUEST,
+              "Missing feature store: " + transformerFeatureStore);
+        }
+      }

Review Comment:
   let me rephrase it:
   what happens if you entirely remove this block
   `// check for non-existent feature store name
          if (transformerFeatureStore != null) {
            if 
(!featureStores.getStores().containsKey(transformerFeatureStore)) {
              throw new SolrException(
                  SolrException.ErrorCode.BAD_REQUEST,
                  "Missing feature store: " + transformerFeatureStore);
            }
          }`
          
          Shouldn't 'final FeatureStore store = 
featureStores.getFeatureStore(transformerFeatureStore);' raise the same 
exception?
          



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org