[GitHub] [solr] janhoy commented on a change in pull request #643: Cleanup CHANGES.txt on branch_9_0

janhoy commented on a change in pull request #643: URL: https://github.com/apache/solr/pull/643#discussion_r807815482 ## File path: solr/CHANGES.txt ## @@ -271,6 +247,89 @@ Build * SOLR-15992: Globally forbid and exclude known bad dependencies (Kevin Risden) +Docker Revie

[jira] [Resolved] (SOLR-16014) Where can I run Streaming Expression in Solr. Also how can I get Cosine Similarity score in response

[ https://issues.apache.org/jira/browse/SOLR-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16014. Resolution: Invalid Please raise questions on the users mailing list (https://solr.apache.org/comm

[jira] [Commented] (SOLR-15965) PKIAuthenticationPlugin uses encryption instead of signatures

[ https://issues.apache.org/jira/browse/SOLR-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493183#comment-17493183 ] Jan Høydahl commented on SOLR-15965: Trying to grasp the instructions in [https://gi

[GitHub] [solr] chatman commented on a change in pull request #644: SOLR-15996: disabling PerReplicaState was resulting in DOWN replicas

chatman commented on a change in pull request #644: URL: https://github.com/apache/solr/pull/644#discussion_r808036618 ## File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java ## @@ -19,14 +19,7 @@ import java.io.Closeable; import java.io.IOException; import java

[jira] [Commented] (SOLR-16013) Overseer gives up election node before closing - inflight commands can be processed twice

[ https://issues.apache.org/jira/browse/SOLR-16013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493279#comment-17493279 ] Andrzej Bialecki commented on SOLR-16013: - Additionally, `OverseerElectionContext

[GitHub] [solr] janhoy merged pull request #593: SOLR-15950 Create SOLR_HOME/filestore lazily on first use

janhoy merged pull request #593: URL: https://github.com/apache/solr/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493290#comment-17493290 ] ASF subversion and git services commented on SOLR-15950: Commit 6

[jira] [Comment Edited] (SOLR-16013) Overseer gives up election node before closing - inflight commands can be processed twice

[ https://issues.apache.org/jira/browse/SOLR-16013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493279#comment-17493279 ] Andrzej Bialecki edited comment on SOLR-16013 at 2/16/22, 3:30 PM:

[jira] [Resolved] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15950. Fix Version/s: 9.0 Resolution: Fixed > Create SOLR_HOME/filestore lazily on first use >

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493300#comment-17493300 ] ASF subversion and git services commented on SOLR-15950: Commit e

[jira] [Commented] (SOLR-15950) Create SOLR_HOME/filestore lazily on first use

[ https://issues.apache.org/jira/browse/SOLR-15950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493301#comment-17493301 ] ASF subversion and git services commented on SOLR-15950: Commit c

[GitHub] [solr] madrob commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

madrob commented on a change in pull request #638: URL: https://github.com/apache/solr/pull/638#discussion_r808143858 ## File path: solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc ## @@ -311,7 +311,5 @@ Example has been provided in `sample_techprod

[jira] [Commented] (SOLR-15965) PKIAuthenticationPlugin uses encryption instead of signatures

[ https://issues.apache.org/jira/browse/SOLR-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493338#comment-17493338 ] Mike Drob commented on SOLR-15965: -- > Should we release 8.11.2 first?  This might be he

[GitHub] [solr] HoustonPutman commented on pull request #595: SOLR-15982: Add end time value to backup response

HoustonPutman commented on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1041914290 Ok I think this is good to go. Will merge and backport later today if you don't have any other notes @cpoerschke -- This is an automated message from the Apache Git Service

[GitHub] [solr] madrob commented on a change in pull request #644: SOLR-15996: disabling PerReplicaState was resulting in DOWN replicas

madrob commented on a change in pull request #644: URL: https://github.com/apache/solr/pull/644#discussion_r808279169 ## File path: solr/core/src/java/org/apache/solr/cloud/Overseer.java ## @@ -19,14 +19,7 @@ import java.io.Closeable; import java.io.IOException; import java.

[GitHub] [solr] HoustonPutman commented on pull request #643: Cleanup CHANGES.txt on branch_9_0

HoustonPutman commented on pull request #643: URL: https://github.com/apache/solr/pull/643#issuecomment-1041926673 This looks good to me. I agree with Mike on the library upgrades. But maybe that deserves a section in the upgrade notes instead? Also of note, the 9.1 and 10.0 sections

[GitHub] [solr] madrob commented on a change in pull request #636: SOLR-13989: Create hadoop-auth module

madrob commented on a change in pull request #636: URL: https://github.com/apache/solr/pull/636#discussion_r808282969 ## File path: solr/core/src/java/org/apache/solr/core/snapshots/SolrSnapshotsTool.java ## @@ -227,12 +227,12 @@ public void describeSnapshot(String collectionN

[GitHub] [solr] Caa52 commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

Caa52 commented on a change in pull request #638: URL: https://github.com/apache/solr/pull/638#discussion_r808332415 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -78,11 +78,9 @@ public DocSet createDocSet(SolrIndexSearcher searcher) throws IOE

[jira] [Commented] (SOLR-14928) Remove Overseer ClusterStateUpdater

[ https://issues.apache.org/jira/browse/SOLR-14928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493417#comment-17493417 ] Ilan Ginzburg commented on SOLR-14928: -- [~anshum] This is done. Nothing was actually

[jira] [Commented] (SOLR-15146) Distribute Collection API command execution

[ https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493418#comment-17493418 ] Ilan Ginzburg commented on SOLR-15146: -- [~anshum] when a cluster is configured to do

[GitHub] [solr] magibney commented on pull request #624: SOLR-16002: don't double-cache FilterQuery

magibney commented on pull request #624: URL: https://github.com/apache/solr/pull/624#issuecomment-1042020339 @dsmiley I merged main into this branch (including PR #529), and the test still fails for me without the modifications in SolrIndexSearcher (I'm pretty sure about this). Also ad

[GitHub] [solr] ijioio commented on pull request #595: SOLR-15982: Add end time value to backup response

ijioio commented on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1042023456 @HoustonPutman Oh, I was going to cleanup/update docs today but realized you have already done it,. Thanks! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] ijioio edited a comment on pull request #595: SOLR-15982: Add end time value to backup response

ijioio edited a comment on pull request #595: URL: https://github.com/apache/solr/pull/595#issuecomment-1042023456 @HoustonPutman Oh, I was going to cleanup/update docs today but realized you have already done it. Thanks! -- This is an automated message from the Apache Git Service. To r

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808356737 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -119,10 +128,18 @@ private final int queryResultMaxDocsCached; priv

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808357146 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -854,20 +880,92 @@ private DocSet getAndCacheDocSet(Query query) throws

[GitHub] [solr] madrob commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808362089 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -119,10 +128,18 @@ private final int queryResultMaxDocsCached; privat

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808365564 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -854,20 +880,92 @@ private DocSet getAndCacheDocSet(Query query) throws

[jira] [Created] (SOLR-16015) RestManager, ManagedResource and ManagedResourceStorage do very verbose logging

Mike Drob created SOLR-16015: Summary: RestManager, ManagedResource and ManagedResourceStorage do very verbose logging Key: SOLR-16015 URL: https://issues.apache.org/jira/browse/SOLR-16015 Project: Solr

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808369044 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Created] (SOLR-16016) RestTestBase will throw Exceptions instead of failing tests

Mike Drob created SOLR-16016: Summary: RestTestBase will throw Exceptions instead of failing tests Key: SOLR-16016 URL: https://issues.apache.org/jira/browse/SOLR-16016 Project: Solr Issue Type:

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808373074 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808376655 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808379629 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808381274 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] janhoy commented on pull request #643: Cleanup CHANGES.txt on branch_9_0

janhoy commented on pull request #643: URL: https://github.com/apache/solr/pull/643#issuecomment-1042105986 I saw it, great If you want to fix that, it is in addVersion.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [solr] dsmiley commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

dsmiley commented on a change in pull request #638: URL: https://github.com/apache/solr/pull/638#discussion_r808410660 ## File path: solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc ## @@ -311,7 +311,5 @@ Example has been provided in `sample_techpro

[GitHub] [solr] dsmiley commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

dsmiley commented on a change in pull request #638: URL: https://github.com/apache/solr/pull/638#discussion_r808411400 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -78,11 +78,9 @@ public DocSet createDocSet(SolrIndexSearcher searcher) throws I

[GitHub] [solr] dsmiley commented on a change in pull request #638: SOLR-12336: DocSetQuery can have 1 score

dsmiley commented on a change in pull request #638: URL: https://github.com/apache/solr/pull/638#discussion_r808410660 ## File path: solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc ## @@ -311,7 +311,5 @@ Example has been provided in `sample_techpro

[GitHub] [solr-operator] HoustonPutman closed issue #385: Solr can't connect to Zookeeper

HoustonPutman closed issue #385: URL: https://github.com/apache/solr-operator/issues/385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman commented on issue #385: Solr can't connect to Zookeeper

HoustonPutman commented on issue #385: URL: https://github.com/apache/solr-operator/issues/385#issuecomment-1042226593 Ok after a lot of digging, I think I know what is happening, and it is unrelated to Solr or the Solr Operator. Basically, the Zookeeper Operator uses/builds its own

[GitHub] [solr-operator] HoustonPutman commented on issue #385: Solr can't connect to Zookeeper

HoustonPutman commented on issue #385: URL: https://github.com/apache/solr-operator/issues/385#issuecomment-1042258723 Actually I see that Solr also cannot resolve the ZK address. This is probably because the Zookeeper Pods can never become healthy, and the ZK Headless service does n

[jira] [Commented] (SOLR-15965) PKIAuthenticationPlugin uses encryption instead of signatures

[ https://issues.apache.org/jira/browse/SOLR-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493503#comment-17493503 ] Jan Høydahl commented on SOLR-15965: I'd prefer to release 9.0 first. Perhaps we can

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808356737 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -119,10 +128,18 @@ private final int queryResultMaxDocsCached; priv

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808455051 ## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ## @@ -854,20 +880,92 @@ private DocSet getAndCacheDocSet(Query query) throws

[GitHub] [solr] magibney commented on a change in pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808458486 ## File path: solr/core/src/test/org/apache/solr/search/TestMainQueryCaching.java ## @@ -0,0 +1,313 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] magibney commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1042317609 Thanks for the feedback, @madrob. I think everything should be addressed now except for the [unit test](#discussion_r806048246) for `copyTo(...)`, which will take a bit more time b

[GitHub] [solr] madrob opened a new pull request #645: SOLR-15333 Fix SpatialRecursivePrefixTreeFieldType schema definition warnings

madrob opened a new pull request #645: URL: https://github.com/apache/solr/pull/645 Co-authored-by: Steffen Moldenhauer https://issues.apache.org/jira/browse/SOLR-15333 Tested with unit tests, and with manual inspection of `docker run --rm -it apache/solr:10.0.0-SNAPSHOT solr

[jira] [Commented] (SOLR-15333) Solr-demo in docker uses improper configuration for SpatialRecursivePrefixTreeFieldType

[ https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493514#comment-17493514 ] Mike Drob commented on SOLR-15333: -- I looked at this some more, expanded the test with t

[GitHub] [solr] magibney commented on pull request #592: SOLR-14765: Optimize DocList creation by skipping sort for sort-irrelevant cases

magibney commented on pull request #592: URL: https://github.com/apache/solr/pull/592#issuecomment-1042325715 As a result of 14f7ac5434626e5d3a068b8c2489b0d604171daa, we could revert the addition of the `asyncHits` metric to `CaffeineCache.java`. I think it's a potentially useful metric? B

[GitHub] [solr] HoustonPutman commented on pull request #629: SOLR-15064 _route_ shouldn't be a fallback for a blank _root_

HoustonPutman commented on pull request #629: URL: https://github.com/apache/solr/pull/629#issuecomment-1042380759 This is not extremely relevant to this PR, but it's something I ran into recently and this is an opportune time to bring it up 🙂 Due to the major refactoring you did ea

[GitHub] [solr] noblepaul commented on a change in pull request #644: SOLR-15996: disabling PerReplicaState was resulting in DOWN replicas

noblepaul commented on a change in pull request #644: URL: https://github.com/apache/solr/pull/644#discussion_r808533716 ## File path: solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java ## @@ -55,7 +55,8 @@ public ZkWriteCommand createShard(final ClusterS

[GitHub] [solr] noblepaul commented on a change in pull request #644: SOLR-15996: disabling PerReplicaState was resulting in DOWN replicas

noblepaul commented on a change in pull request #644: URL: https://github.com/apache/solr/pull/644#discussion_r808536170 ## File path: solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java ## @@ -160,6 +164,38 @@ public ZkWriteCommand modifyCollection(final

[jira] [Created] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

Michael Gibney created SOLR-16017: - Summary: Allow first registered SolrIndexSearcher to inform its configured caches Key: SOLR-16017 URL: https://issues.apache.org/jira/browse/SOLR-16017 Project: Sol

[GitHub] [solr] magibney opened a new pull request #646: SOLR-16017: Allow first registered SolrIndexSearcher to inform its configured caches

magibney opened a new pull request #646: URL: https://github.com/apache/solr/pull/646 See: [SOLR-16017](https://issues.apache.org/jira/browse/SOLR-16017) add a hook for initializing caches by passing a reference to the first registered searcher This complements (and is analogo

[jira] [Commented] (SOLR-16017) Allow first registered SolrIndexSearcher to inform its configured caches

[ https://issues.apache.org/jira/browse/SOLR-16017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493625#comment-17493625 ] Michael Gibney commented on SOLR-16017: --- [PR #646|https://github.com/apache/solr/pu

[jira] [Commented] (SOLR-15578) Add Support for HSTS Security Protocol

[ https://issues.apache.org/jira/browse/SOLR-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493710#comment-17493710 ] Andras Salamon commented on SOLR-15578: --- I agree with [~marcussorealheis] this miss

[jira] [Commented] (SOLR-15333) Solr-demo in docker uses improper configuration for SpatialRecursivePrefixTreeFieldType

[ https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493738#comment-17493738 ] Steffen Moldenhauer commented on SOLR-15333: [~mdrob] Thanks for the mention.