madrob commented on a change in pull request #592: URL: https://github.com/apache/solr/pull/592#discussion_r808362089
########## File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java ########## @@ -119,10 +128,18 @@ private final int queryResultMaxDocsCached; private final boolean useFilterForSortedQuery; + /** + * Special-case cache to handle the lazy-init of {@link #liveDocs}. + */ + private final SolrCache<MatchAllDocsQuery,BitDocSet> liveDocsCache; Review comment: I don't feel strongly about it, and would be satisfied with an additional line in the comment saying why it is what it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org