madrob commented on a change in pull request #636:
URL: https://github.com/apache/solr/pull/636#discussion_r808282969
##########
File path:
solr/core/src/java/org/apache/solr/core/snapshots/SolrSnapshotsTool.java
##########
@@ -227,12 +227,12 @@ public void describeSnapshot(String collectionName,
String snapshotName) {
String indexDirPath = coreSnap.getIndexDirPath();
if (pathPrefix != null) {
// If the path prefix is specified, rebuild the path to the index
directory.
- indexDirPath = new Path(pathPrefix,
coreSnap.getIndexDirPath()).toString();
+ indexDirPath = Path.of(pathPrefix,
coreSnap.getIndexDirPath()).toString();
}
List<String> paths = new ArrayList<>();
for (String fileName : coreSnap.getFiles()) {
- Path p = new Path(indexDirPath, fileName);
+ Path p = Path.of(indexDirPath, fileName);
Review comment:
If we're doing this, leave indexDirPath as a Path and call `resolve()`
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
