[
https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493514#comment-17493514
]
Mike Drob commented on SOLR-15333:
----------------------------------
I looked at this some more, expanded the test with two more scenarios (adding
redundant field type, adding invariant violating field type) which led me to
some more debug fixes since I couldn't understand the log output very easily. I
also reverted a lot of the logic that was added, going back to mostly inline
with the original method, since after testing it turned out to be almost
exactly what we needed already. Instead of adding the properties like in the
current code, we needed to remove them and set the properties flag directly
like in the patch.
[~smoldenhauer] do you have an email address you would like affiliated with the
commit for co-author credit, since it was your work that unlocked a lot of my
own understanding?
Please review the PR up at https://github.com/apache/solr/pull/645
> Solr-demo in docker uses improper configuration for
> SpatialRecursivePrefixTreeFieldType
> ---------------------------------------------------------------------------------------
>
> Key: SOLR-15333
> URL: https://issues.apache.org/jira/browse/SOLR-15333
> Project: Solr
> Issue Type: Task
> Affects Versions: 8.8.2
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Major
> Attachments: SOLR-15333-1.patch, SOLR-15333.patch, SOLR-15333.patch,
> SOLR-15333_test.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be
> specified in schema,​ hardcoded behavior is omitNorms=true
> 4/13/2021, 4:54:42 PM
> WARN false
> x:demo
> AbstractSpatialPrefixTreeFieldType
> FieldType SpatialRecursivePrefixTreeFieldType does not allow
> omitTermFreqAndPositions to be specified in schema,​ hardcoded behavior
> is omitTermFreqAndPositions=true
> 4/13/2021, 4:54:42 PM
> When running solr-demo with our docker images, we get a bunch of warnings:
> {noformat}
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitNorms to be
> specified in schema,​ hardcoded behavior is omitNorms=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow
> omitTermFreqAndPositions to be specified in schema,​ hardcoded behavior
> is omitTermFreqAndPositions=true
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termOffsets to
> be specified in schema,​ hardcoded behavior is termOffsets=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow termPositions to
> be specified in schema,​ hardcoded behavior is termPositions=false
> FieldType SpatialRecursivePrefixTreeFieldType does not allow omitPositions to
> be specified in schema,​ hardcoded behavior is omitPositions=true
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
