[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-04-26 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17528235#comment-17528235 ] Kevin Risden commented on SOLR-14920: - SOLR-16070 is merged meaning that for 9.1 all

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-09 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503665#comment-17503665 ] Erick Erickson commented on SOLR-14920: --- [~krisden]  I’m pretty sure I pushed the f

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-07 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502415#comment-17502415 ] Kevin Risden commented on SOLR-14920: - Only "solr/solrj/src/test/org/apache/solr/clie

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502408#comment-17502408 ] ASF subversion and git services commented on SOLR-14920: Commit b

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502403#comment-17502403 ] ASF subversion and git services commented on SOLR-14920: Commit 8

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502404#comment-17502404 ] ASF subversion and git services commented on SOLR-14920: Commit 9

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-05 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501832#comment-17501832 ] Kevin Risden commented on SOLR-14920: - All major spotless changes except for "solr/s

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501828#comment-17501828 ] ASF subversion and git services commented on SOLR-14920: Commit b

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501827#comment-17501827 ] ASF subversion and git services commented on SOLR-14920: Commit 2

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501485#comment-17501485 ] ASF subversion and git services commented on SOLR-14920: Commit 5

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501489#comment-17501489 ] Kevin Risden commented on SOLR-14920: - Core non test has been pushed to main and bran

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501487#comment-17501487 ] Kevin Risden commented on SOLR-14920: - Thanks [~erickerickson] appreciate all the hel

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501484#comment-17501484 ] ASF subversion and git services commented on SOLR-14920: Commit 7

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501466#comment-17501466 ] ASF subversion and git services commented on SOLR-14920: Commit c

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501457#comment-17501457 ] ASF subversion and git services commented on SOLR-14920: Commit 7

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501362#comment-17501362 ] Erick Erickson commented on SOLR-14920: --- finished reviewing 705. The usual nits, bu

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-03 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501019#comment-17501019 ] Kevin Risden commented on SOLR-14920: - solr core non test is being reviewed and proba

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-03 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500928#comment-17500928 ] Kevin Risden commented on SOLR-14920: - {quote}I definitely think the scope should inc

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-03 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500815#comment-17500815 ] Erick Erickson commented on SOLR-14920: --- I'll start looking at 705. > Format code

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500418#comment-17500418 ] David Smiley commented on SOLR-14920: - I definitely think the scope should include fo

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-02 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500343#comment-17500343 ] Erick Erickson commented on SOLR-14920: --- Finished review of 711, see the comments t

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-02 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500178#comment-17500178 ] Kevin Risden commented on SOLR-14920: - solr core test only merged to branch_9_0 solr

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500155#comment-17500155 ] ASF subversion and git services commented on SOLR-14920: Commit 7

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499834#comment-17499834 ] Kevin Risden commented on SOLR-14920: - solr core non test is ready for review: https:

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499782#comment-17499782 ] Kevin Risden commented on SOLR-14920: - Ok minus the minor hiccup around XMLResponsePa

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499754#comment-17499754 ] ASF subversion and git services commented on SOLR-14920: Commit 4

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499750#comment-17499750 ] ASF subversion and git services commented on SOLR-14920: Commit 7

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499744#comment-17499744 ] ASF subversion and git services commented on SOLR-14920: Commit 9

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499742#comment-17499742 ] ASF subversion and git services commented on SOLR-14920: Commit 0

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499738#comment-17499738 ] Kevin Risden commented on SOLR-14920: - Chatted w/ [~mdrob] on Slack. There are 3 sam

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499737#comment-17499737 ] ASF subversion and git services commented on SOLR-14920: Commit 8

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499725#comment-17499725 ] ASF subversion and git services commented on SOLR-14920: Commit e

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499720#comment-17499720 ] Kevin Risden commented on SOLR-14920: - Yea I can't seem to reproduce. I emailed solr-

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499713#comment-17499713 ] Mike Drob commented on SOLR-14920: -- Very strangely, I'm getting formatting errors only o

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499560#comment-17499560 ] Kevin Risden commented on SOLR-14920: - [~erickerickson] I pulled your https://github.

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-03-01 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499520#comment-17499520 ] Erick Erickson commented on SOLR-14920: --- I'll see if I can get to 711. Reminder, 7

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499297#comment-17499297 ] Kevin Risden commented on SOLR-14920: - merged solrj spotless formatting to branch_9_0

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499296#comment-17499296 ] ASF subversion and git services commented on SOLR-14920: Commit 0

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499189#comment-17499189 ] Kevin Risden commented on SOLR-14920: - Now that solrj is merged. solr core non test

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499184#comment-17499184 ] Kevin Risden commented on SOLR-14920: - merged solrj spotless formatting to main and b

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499183#comment-17499183 ] ASF subversion and git services commented on SOLR-14920: Commit 5

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499180#comment-17499180 ] ASF subversion and git services commented on SOLR-14920: Commit f

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-26 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498522#comment-17498522 ] Erick Erickson commented on SOLR-14920: --- [~krisden]  I finished PR 706... My comme

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-26 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498448#comment-17498448 ] Erick Erickson commented on SOLR-14920: --- PR #713 has all the solrj/stream/io change

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Sajid Sajid (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498384#comment-17498384 ] Sajid Sajid commented on SOLR-14920: Hello > Format code automatically and enforce i

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498312#comment-17498312 ] Kevin Risden commented on SOLR-14920: - For Solr Core - I put up two PRs and working t

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498301#comment-17498301 ] Erick Erickson commented on SOLR-14920: --- [~krisden]. OK, I'll grab solr/solrj/src/

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498251#comment-17498251 ] ASF subversion and git services commented on SOLR-14920: Commit 5

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498246#comment-17498246 ] Kevin Risden commented on SOLR-14920: - test-framework spotless change merged to branc

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498233#comment-17498233 ] Kevin Risden commented on SOLR-14920: - solrj spotless is ready for review - https://g

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498232#comment-17498232 ] Kevin Risden commented on SOLR-14920: - At least wanted to make sure it went ok in bra

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498200#comment-17498200 ] David Smiley commented on SOLR-14920: - Why not 9_0? I think we should have all of 9

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498190#comment-17498190 ] Kevin Risden commented on SOLR-14920: - test-framework spotless change merged to main

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498189#comment-17498189 ] ASF subversion and git services commented on SOLR-14920: Commit 5

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498188#comment-17498188 ] ASF subversion and git services commented on SOLR-14920: Commit 2

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-25 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17498169#comment-17498169 ] Kevin Risden commented on SOLR-14920: - So test-framework is being reviewed here: htt

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497844#comment-17497844 ] Erick Erickson commented on SOLR-14920: --- [~dsmiley]  I totally agree that spotless

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497837#comment-17497837 ] Erick Erickson commented on SOLR-14920: --- Well, it went faster the second time aroun

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497797#comment-17497797 ] David Smiley commented on SOLR-14920: - [~erickerickson] Sometimes the reformatted cod

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497773#comment-17497773 ] Kevin Risden commented on SOLR-14920: - So test-framework is definitely reasonable to

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497771#comment-17497771 ] Erick Erickson commented on SOLR-14920: --- How brave do you want to be? Has anyone fo

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497748#comment-17497748 ] Kevin Risden commented on SOLR-14920: - Example of what test-framework looks like as a

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497493#comment-17497493 ] Houston Putman commented on SOLR-14920: --- The test framework can also likely be done

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497476#comment-17497476 ] Kevin Risden commented on SOLR-14920: - Sorry [~erickerickson] saw your message and th

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-24 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497445#comment-17497445 ] Erick Erickson commented on SOLR-14920: --- Hello? Hello? I feel like I'm shouting dow

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496885#comment-17496885 ] ASF subversion and git services commented on SOLR-14920: Commit f

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496884#comment-17496884 ] ASF subversion and git services commented on SOLR-14920: Commit 3

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496882#comment-17496882 ] ASF subversion and git services commented on SOLR-14920: Commit 1

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-23 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496794#comment-17496794 ] Erick Erickson commented on SOLR-14920: --- [~krisden] [~cpoerschke]  I formatted solr

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-22 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496268#comment-17496268 ] Erick Erickson commented on SOLR-14920: --- I'll put up a PR shortly that has core, so

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496133#comment-17496133 ] Kevin Risden commented on SOLR-14920: - All the modules except for ltr (backport in pr

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-22 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496123#comment-17496123 ] Kevin Risden commented on SOLR-14920: - PR for branch 9_0 .git-blame-ignore-revs after

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495777#comment-17495777 ] ASF subversion and git services commented on SOLR-14920: Commit c

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495775#comment-17495775 ] ASF subversion and git services commented on SOLR-14920: Commit 9

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495776#comment-17495776 ] ASF subversion and git services commented on SOLR-14920: Commit d

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495774#comment-17495774 ] Kevin Risden commented on SOLR-14920: - [~dsmiley] not sure I follow. Each branch has

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495769#comment-17495769 ] David Smiley commented on SOLR-14920: - Can we do one PR for the updates to .git-blame

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495768#comment-17495768 ] Kevin Risden commented on SOLR-14920: - Thanks [~houston] - opened https://github.com/

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495767#comment-17495767 ] Kevin Risden commented on SOLR-14920: - PR for main to add the module spotless specifi

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495627#comment-17495627 ] Houston Putman commented on SOLR-14920: --- *solr-ref-guide* no longer has any non-exa

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495622#comment-17495622 ] ASF subversion and git services commented on SOLR-14920: Commit 1

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495612#comment-17495612 ] ASF subversion and git services commented on SOLR-14920: Commit 1

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495614#comment-17495614 ] ASF subversion and git services commented on SOLR-14920: Commit 0

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495592#comment-17495592 ] Kevin Risden commented on SOLR-14920: - As of right now, all the contrib/modules have

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495590#comment-17495590 ] Erick Erickson commented on SOLR-14920: --- It's vaguely possible that I can help here

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-21 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495498#comment-17495498 ] Christine Poerschke commented on SOLR-14920: Separate Jira issues per modules

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494999#comment-17494999 ] Kevin Risden commented on SOLR-14920: - Easier for me at least to keep track of as ind

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-19 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494998#comment-17494998 ] David Smiley commented on SOLR-14920: - I don't think we need a Jira issue per module

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2022-02-19 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494994#comment-17494994 ] Kevin Risden commented on SOLR-14920: - I created linked tickets for a ton of the exce

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-15 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363722#comment-17363722 ] Christine Poerschke commented on SOLR-14920: Just a note to say that the abov

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363202#comment-17363202 ] ASF subversion and git services commented on SOLR-14920: Commit 6

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363196#comment-17363196 ] ASF subversion and git services commented on SOLR-14920: Commit d

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-07 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358852#comment-17358852 ] Christine Poerschke commented on SOLR-14920: Hi [~dweiss]. [~dsmiley] had sug

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357519#comment-17357519 ] Dawid Weiss commented on SOLR-14920: Hi Christine. Solr's repository still has roots

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357498#comment-17357498 ] ASF subversion and git services commented on SOLR-14920: Commit d

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357488#comment-17357488 ] Mike Drob commented on SOLR-14920: -- >  Or is it just time to carry this forward and let

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357347#comment-17357347 ] Erick Erickson commented on SOLR-14920: --- So I'll raise the question, then stay out

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-06-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17357200#comment-17357200 ] ASF subversion and git services commented on SOLR-14920: Commit a

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-05-13 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344360#comment-17344360 ] Dawid Weiss commented on SOLR-14920: This is how it was done for Lucene - step by ste

[jira] [Commented] (SOLR-14920) Format code automatically and enforce it in Solr

2021-05-13 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344144#comment-17344144 ] Christine Poerschke commented on SOLR-14920: bq. ... Maybe we could start wit

  1   2   >