[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501362#comment-17501362
]
Erick Erickson commented on SOLR-14920:
---------------------------------------
finished reviewing 705. The usual nits, but only 21 of them, which ya gotta
admit is pretty remarkable given the number of files changed.
Nothing functional, mostly odd breaks.
I've no doubt that another review would find more, just due to the sheer
volume; we're past diminishing returns I think.
[~ctargett] (or whoever runs javadocs next). Lots and lots and lots of
reformatting happened in the javadocs, but the all appear to be harmless;
things like:
{quote}<p>
some text
{quote}
becoming
{quote}<p>some text
{quote}
which theoretically shouldn't matter. This is juspit a heads up if something
weird pops out you'll know who to have fix it...
I'll be away on a road trip for the next couple of weeks so I won't be doing
anything more unless someone pings me directly and I can answer via e-mail.
Leaving my computer at home...
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Kevin Risden
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 17h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
