[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501019#comment-17501019
]
Kevin Risden commented on SOLR-14920:
-------------------------------------
solr core non test is being reviewed and probably close to merge:
https://github.com/apache/solr/pull/705
[~erickerickson] did a thorough review of some of the Spotless changes and
those are being addressed in https://github.com/apache/solr/pull/720
I created 3 draft PRs for adding the recent spotless commits to
.git-blame-ignore-revs:
* main - https://github.com/apache/solr/pull/721
* branch_9x - https://github.com/apache/solr/pull/722
* branch_9_0 - https://github.com/apache/solr/pull/723
The above PRs need to be updated after the first two PRs are merged.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Kevin Risden
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
