[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358852#comment-17358852
]
Christine Poerschke commented on SOLR-14920:
--------------------------------------------
Hi [~dweiss]. [~dsmiley] had suggested on [PR
162|https://github.com/apache/solr/pull/162#issuecomment-854778916] about
wiping clean of the "lucene" commits and whilst I created the SOLR-15454
"remove Lucene commits from .git-blame-ignore-revs" sub-task for it (since it
is more to do with the repo split effort than the automatic code formatting
effort here) and was glad to learn about that new git option I hadn't come
across before, well in the mids of all that to be honest I didn't consider if
the _"should be wiped clean"_ is maybe more _"could be wiped clean"_ instead.
So thanks for catching this, and really I can see it both ways and have no
strong views either way really.
[https://github.com/apache/solr/pull/163] is currently scoped as "SOLR-15454,
SOLR-14920: remove Lucene commits from .git-blame-ignore-revs and add Solr
commits placeholder" and I will rescope it to "SOLR-15454: remove Lucene
commits from .git-blame-ignore-revs" with the suggestion to continue the "to
wipe or not to wipe" discussion on SOLR-15454 then.
> Format code automatically and enforce it in Solr
> ------------------------------------------------
>
> Key: SOLR-14920
> URL: https://issues.apache.org/jira/browse/SOLR-14920
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Priority: Major
> Labels: codestyle, formatting
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> See the discussion at: LUCENE-9564.
> This is a placeholder for the present, I'm reluctant to do this to the Solr
> code base until after:
> * we have some Solr-specific consensus
> * we have some clue what this means for the reference impl.
> Reconciling the reference impl will be difficult enough without a zillion
> format changes to add to the confusion.
> So my proposal is
> 1> do this.
> 2> Postpone this until after the reference impl is merged.
> 3> do this in one single commit for reasons like being able to conveniently
> have this separated out from git blame.
> Assigning to myself so it doesn't get lost, but anyone who wants to take it
> over please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
