Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]

2025-04-16 Thread via GitHub
1995chen closed pull request #3278: feat: support specifying the configuration of the checkpoint collection URL: https://github.com/apache/solr/pull/3278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047753765 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java: ## @@ -130,29 +134,35 @@ protected MetricSamples request(SolrClient client,

[jira] [Commented] (SOLR-17740) JAX-RS V2 API requests with payloads can skip first byte

2025-04-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945176#comment-17945176 ] David Smiley commented on SOLR-17740: - After looking deeper at why PushbackInputStrea

Re: [PR] Bump golang.org/x/net from 0.33.0 to 0.36.0 [solr-operator]

2025-04-16 Thread via GitHub
dependabot[bot] commented on PR #765: URL: https://github.com/apache/solr-operator/pull/765#issuecomment-2811041877 Superseded by #784. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] SOLR-15546: ShortestPathStream to handle ids with colons. [solr]

2025-04-16 Thread via GitHub
github-actions[bot] commented on PR #236: URL: https://github.com/apache/solr/pull/236#issuecomment-2811255238 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be famil

Re: [PR] Bump golang.org/x/net from 0.33.0 to 0.36.0 [solr-operator]

2025-04-16 Thread via GitHub
dependabot[bot] closed pull request #765: Bump golang.org/x/net from 0.33.0 to 0.36.0 URL: https://github.com/apache/solr-operator/pull/765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] Bump golang.org/x/net from 0.33.0 to 0.38.0 [solr-operator]

2025-04-16 Thread via GitHub
dependabot[bot] opened a new pull request, #784: URL: https://github.com/apache/solr-operator/pull/784 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.33.0 to 0.38.0. Commits https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9";>e1fcd82

Re: [PR] Optimize consumeInputFully, don't loop read single byte [solr]

2025-04-16 Thread via GitHub
dsmiley commented on code in PR #3323: URL: https://github.com/apache/solr/pull/3323#discussion_r2047863829 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -252,8 +253,11 @@ private static void traceHttpRequestExecution2( static void consumeInputFully(H

Re: [PR] Optimize consumeInputFully, don't loop read single byte [solr]

2025-04-16 Thread via GitHub
madrob commented on code in PR #3323: URL: https://github.com/apache/solr/pull/3323#discussion_r2047893407 ## solr/solrj/src/java/org/apache/solr/common/util/Utils.java: ## @@ -664,8 +665,13 @@ public static void consumeFully(HttpEntity entity) { * @throws IOException on pro

Re: [PR] SOLR-17740: V2 API: fix raw file uploads missing 1st byte [solr]

2025-04-16 Thread via GitHub
dsmiley commented on PR #3322: URL: https://github.com/apache/solr/pull/3322#issuecomment-2810941125 Thank you for prodding me on the reasoning behind the PushbackInputStream being there in the first place. After looking deeper, it was added back in SOLR-15418 (me to fix another bug for v2

Re: [PR] Optimize consumeInputFully, don't loop read single byte [solr]

2025-04-16 Thread via GitHub
risdenk commented on code in PR #3323: URL: https://github.com/apache/solr/pull/3323#discussion_r2047756177 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -252,8 +253,11 @@ private static void traceHttpRequestExecution2( static void consumeInputFully(H

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047713433 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java: ## @@ -666,11 +669,13 @@ public void testNonRetryableRequests() throws Exception {

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047689209 ## solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java: ## @@ -479,8 +485,9 @@ void setPropWithStandardRequest(Slice slice, Replica rep, String prop)

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047754065 ## solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java: ## @@ -445,10 +449,12 @@ private void rebalancePropUsingStandardRequest(String prop) if (p

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on PR #3238: URL: https://github.com/apache/solr/pull/3238#issuecomment-2810718828 Hoping to move this along a bit, I've pushed some fixes to address some of @dsmiley 's smaller style comments. I still have a few more to go, and then will need to re-test, etc. B

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047697653 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java: ## @@ -130,29 +134,35 @@ protected MetricSamples request(SolrClient client,

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047712486 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -730,11 +733,14 @@ public void testNonRetryableRequests() throws Exceptio

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047711676 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java: ## @@ -138,8 +136,9 @@ public Set getUrlParamNames() { public CompletableFuture req

Re: [PR] SOLR-17043: Remove SolrClient path pattern matching [solr]

2025-04-16 Thread via GitHub
gerlowskija commented on code in PR #3238: URL: https://github.com/apache/solr/pull/3238#discussion_r2047698897 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1001,25 +999,30 @@ protected NamedList sendRequest(SolrRequest request, List inp

Re: [PR] SOLR-17736: introducing support for KNN search on nested vectors (block join) [solr]

2025-04-16 Thread via GitHub
alessandrobenedetti commented on code in PR #3316: URL: https://github.com/apache/solr/pull/3316#discussion_r2047340978 ## solr/core/src/java/org/apache/solr/search/join/BlockJoinParentQParser.java: ## @@ -78,10 +93,127 @@ protected Query noClausesQuery() throws SyntaxError {

Re: [PR] SOLR-17736: introducing support for KNN search on nested vectors (block join) [solr]

2025-04-16 Thread via GitHub
alessandrobenedetti commented on code in PR #3316: URL: https://github.com/apache/solr/pull/3316#discussion_r2047337900 ## solr/core/src/java/org/apache/solr/search/join/BlockJoinParentQParser.java: ## @@ -78,10 +93,127 @@ protected Query noClausesQuery() throws SyntaxError {

Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]

2025-04-16 Thread via GitHub
epugh commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2810099575 @1995chen looks like you have some precommit errors to fix? Also, for this change, I don't see a unit test, do we have that already covered? I also would like some updates to the Re

Re: [PR] SOLR-17736: introducing support for KNN search on nested vectors (block join) [solr]

2025-04-16 Thread via GitHub
alessandrobenedetti commented on code in PR #3316: URL: https://github.com/apache/solr/pull/3316#discussion_r2047275605 ## solr/core/src/java/org/apache/solr/search/join/BlockJoinParentQParser.java: ## @@ -78,10 +93,127 @@ protected Query noClausesQuery() throws SyntaxError {

Re: [PR] SOLR-16903: Make java.io.File a forbidden API [solr]

2025-04-16 Thread via GitHub
mlbiscoc commented on code in PR #3321: URL: https://github.com/apache/solr/pull/3321#discussion_r2046935800 ## solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java: ## @@ -104,9 +105,7 @@ public static void beforeClass() throws Exception

[jira] [Updated] (SOLR-17726) CloudMLTQParser fails to use copyFields due to RealTime Get

2025-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17726: -- Labels: morelikethis pull-request-available (was: morelikethis) > CloudMLTQParser fails to use

[PR] [SOLR-17726] Fix CloudMLTQParser to support copyField in qf [solr]

2025-04-16 Thread via GitHub
ilariapet opened a new pull request, #3328: URL: https://github.com/apache/solr/pull/3328 https://issues.apache.org/jira/browse/SOLR-17726 # Description When using CloudMLTQParser, fields that are populated exclusively via `copyField` are not taken into account when con

[jira] [Resolved] (SOLR-17636) add BPReorderingMergePolicyFactory class

2025-04-16 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke resolved SOLR-17636. Fix Version/s: main (10.0) 9.9 Resolution: Fixed > add BP

[jira] [Commented] (SOLR-17636) add BPReorderingMergePolicyFactory class

2025-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945008#comment-17945008 ] ASF subversion and git services commented on SOLR-17636: Commit 5

Re: [PR] SOLR-17636: make Lucene's BPReorderingMergePolicy configurable in Solr [solr]

2025-04-16 Thread via GitHub
cpoerschke merged PR #2641: URL: https://github.com/apache/solr/pull/2641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[jira] [Commented] (SOLR-17636) add BPReorderingMergePolicyFactory class

2025-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945005#comment-17945005 ] ASF subversion and git services commented on SOLR-17636: Commit 5

Re: [PR] feat: support specifying the configuration of the checkpoint collection [solr]

2025-04-16 Thread via GitHub
cpoerschke commented on PR #3278: URL: https://github.com/apache/solr/pull/3278#issuecomment-2808856754 > @cpoerschke could you please help me review this pr again Unfortunately I'm not sufficiently familiar with this functionality to meaningfully review. Based on https://issue