gerlowskija commented on code in PR #3238:
URL: https://github.com/apache/solr/pull/3238#discussion_r2047753765
##########
solr/prometheus-exporter/src/java/org/apache/solr/prometheus/scraper/SolrScraper.java:
##########
@@ -130,29 +134,35 @@ protected MetricSamples request(SolrClient client,
MetricsQuery query) throws IO
zkHostLabelValue = ((CloudSolrClient)
client).getClusterStateProvider().getQuorumHosts();
}
- QueryRequest queryRequest = new QueryRequest(query.getParameters());
- queryRequest.setPath(query.getPath());
-
- NamedList<Object> queryResponse;
+ SolrRequestType requestType = SolrRequestType.QUERY;
Review Comment:
Done
##########
solr/core/src/test/org/apache/solr/cloud/TestRebalanceLeaders.java:
##########
@@ -445,10 +449,12 @@ private void rebalancePropUsingStandardRequest(String
prop)
if (prop.toLowerCase(Locale.ROOT).contains("preferredleader") == false) {
params.set("shardUnique", true);
}
- QueryRequest request = new QueryRequest(params);
- request.setPath("/admin/collections");
- QueryResponse resp = request.process(cluster.getSolrClient());
- assertEquals("Call to rebalanceLeaders failed ", 0, resp.getStatus());
+ var request =
+ new GenericSolrRequest(METHOD.GET, "/admin/collections",
SolrRequestType.ADMIN, params);
+ request.setRequiresCollection(false);
+ SimpleSolrResponse resp = request.process(cluster.getSolrClient());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
