mlbiscoc commented on code in PR #3321:
URL: https://github.com/apache/solr/pull/3321#discussion_r2046935800
##########
solr/modules/jwt-auth/src/test/org/apache/solr/security/jwt/JWTAuthPluginIntegrationTest.java:
##########
@@ -104,9 +105,7 @@ public static void beforeClass() throws Exception {
pemFilePath =
JWT_TEST_PATH().resolve("security").resolve("jwt_plugin_idp_cert.pem");
wrongPemFilePath =
JWT_TEST_PATH().resolve("security").resolve("jwt_plugin_idp_wrongcert.pem");
- Path tempDir =
Files.createTempDirectory(JWTAuthPluginIntegrationTest.class.getSimpleName());
- tempDir.toFile().deleteOnExit();
-
+ Path tempDir = FilterPath.unwrap(createTempDir());
Path modifiedP12Cert = tempDir.resolve(p12Cert.getFileName());
Review Comment:
Need to unwrap to resolve the path
##########
solr/CHANGES.txt:
##########
@@ -152,12 +152,10 @@ Other Changes
* SOLR-17321: Minimum Java version for Apache Solr is now 21, and for SolrJ,
it is 17. (Sanjay Dutt, David Smiley)
-* SOLR-16903: Update CLI tools and Solr Core to use java.nio.file.Path instead
of java.io.File (Andrey Bozhko, Matthew Biscocho)
+* SOLR-16903: Replace all java.io.File usages to java.nio.file.Path (NIO)
(Andrey Bozhko, Matthew Biscocho)
* SOLR-17568: SolrCloud no longer reroutes/proxies a core request to another
node if not found locally. (David Smiley)
-* SOLR-17548: Switch all public Java APIs from File to Path. (Matthew Biscocho
via Eric Pugh)
-
Review Comment:
Going to just remove this because its implied from the change above anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
