[
https://issues.apache.org/jira/browse/SOLR-17740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945176#comment-17945176
]
David Smiley commented on SOLR-17740:
-------------------------------------
After looking deeper at why PushbackInputStream was added back in SOLR-15418
(me to fix another bug for v2), I'm happy to report I can remove that, and all
tests pass now. In the last 4 years, perhaps some detail changed about v2
pertaining to why I chose that unfortunate solution then.
> JAX-RS V2 API requests with payloads can skip first byte
> --------------------------------------------------------
>
> Key: SOLR-17740
> URL: https://issues.apache.org/jira/browse/SOLR-17740
> Project: Solr
> Issue Type: Bug
> Components: v2 API
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The new V2 API (JAX-RS, Jersey) has its own stack of code between Solr's
> V2HttpCall and the handler, that which doesn't know about the
> SolrQueryRequest. Specifically
> {{org.apache.solr.api.V2HttpCall#handleAdmin}} doesn't use {{solrReq}} as it
> passes on to {{{}invokeJerseyRequest{}}}. But the payload of the request has
> been somewhat parsed already into the ContentStream on SolrQueryRequest, and
> this can sometimes require reading the first byte – see
> {{{}org.apache.solr.servlet.SolrRequestParsers.RawRequestParser#parseParamsAndFillStreams{}}}.
> Consequently V2 requests like FileStore uploadFile can be impacted depending
> on the details of the headers present.
> In practice, Jetty HttpClient intermittently was triggering affected and
> unaffected requests when executing the following test:
> {{./gradlew :solr:core:test --tests
> "org.apache.solr.cli.PackageToolTest.testPackageTool"
> -Ptests.seed=B8415E6AAC736FCD}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
