ilariapet opened a new pull request, #3328: URL: https://github.com/apache/solr/pull/3328
https://issues.apache.org/jira/browse/SOLR-17726 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description When using CloudMLTQParser, fields that are populated exclusively via `copyField` are not taken into account when constructing the MoreLikeThis query. This happens because CloudMLTQParser relies on a RealTime Get (`/get`) request to retrieve the source document by ID, and the document returned by RealTime Get does not include fields generated via copyField (i.e. are not part of the original SolrIDocument). As a result, even if the copyField target is stored and has proper termVectors configured, CloudMLTQParser skips the field silently, and the MLT query ends up empty. # Solution The issue was addressed by introducing a helper method `getFieldOrCopyFieldValues` that retrieves field values from the source document returned by RealTime Get. If a field passed in the `qf` parameter of the MLT query is not directly present in the document (as is the case for fields populated exclusively via copyField), the method looks up its copyField sources in the schema and aggregates their values. These values are then used to construct the input for MoreLikeThis#like, ensuring that all content (including that of copyField-derived fields) is properly considered when building the MLT query. # Tests Five tests were added to cover different scenarios involving copyField usage in the qf parameter of the MoreLikeThis query: - `testUsesACopyFieldInQf_shouldUseTheSourceFieldAndReturnResults` Verifies that when a copyField destination is used in the qf parameter, the MLT query correctly retrieves values from the source field(s) and returns relevant results. - `testCopyFieldSourceMissing_shouldReturnNoResults` Ensures that no results are returned when the copyField source field is missing in the source document. - `testCopyFieldDestinationNotStored_shouldReturnResults` Confirms that even if the copyField destination field is not stored, results can still be returned as long as the source field is stored and contains the relevant content. - `testCopyFieldSourceNotStored_shouldReturnNoResults` Checks that no results are returned if the copyField source field is not stored, even when the destination field is stored and used in the qf. - `testCopyFieldDestinationMultiple_shouldReturnResults` Validates that when multiple source fields map to a single copyField destination, their values are correctly combined to construct the MLT query, and appropriate results are returned. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
